Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrations: Deprecate HeaderMaps #11018

Merged
merged 1 commit into from
Apr 8, 2020
Merged

integrations: Deprecate HeaderMaps #11018

merged 1 commit into from
Apr 8, 2020

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Apr 8, 2020

httptest/ResponseRecorder.HeaderMap is deprecated, and suggests using Header().Get().

see:
go doc httptest.ResponseRecorder.HeaderMap

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 8, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 8, 2020
@techknowlogick techknowlogick merged commit c02dee8 into go-gitea:master Apr 8, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@alrs
integrations: deprecate HeaderMaps (go-gitea#11018)
516d13d
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alrs @zeripath @6543 @techknowlogick @GiteaBot