-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] provide OwnerName
field for README template
#10981
Conversation
Provide more information to readme template
I think we need docs for this ... I'll send a pull for this (#10983) -> based on the merge order either this or the other pr has to add |
Codecov Report
@@ Coverage Diff @@
## master #10981 +/- ##
==========================================
- Coverage 43.63% 43.60% -0.04%
==========================================
Files 597 597
Lines 83923 83924 +1
==========================================
- Hits 36623 36596 -27
- Misses 42787 42811 +24
- Partials 4513 4517 +4
Continue to review full report at Codecov.
|
@everhopingandwaiting since #10983 got merged: |
@everhopingandwaiting a hint: you should make |
should I choose rebase or merge to select upstream changes in my origin branch? |
@everhopingandwaiting If you like to chat with me -> https://discord.gg/Gitea |
seems I should change "Description": repo.Description,
"CloneURL.SSH": cloneLink.SSH, "CloneURL.SSH": cloneLink.SSH,
"CloneURL.HTTPS": cloneLink.HTTPS, "CloneURL.HTTPS": cloneLink.HTTPS,
"OwnerName": repo.OwnerName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking since need addition to docs
just add your |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just "apply"
Co-Authored-By: 6543 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
I wander why this PR is not on any Milestone ? |
on 1.12, but reopen |
@a1012112796 most docs PRs we haven't added milestone because most of them are outdate documents so that we should not mark them on the milestone. |
Co-Authored-By: 6543 <[email protected]> Co-authored-by: techknowlogick <[email protected]>
reopen: pr #10356