Users should not be able to prohibit their own login #10970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I think it's crazy and not reasonale , that if a user can prohibit themself to login. so suggest limit this choice on ui Signed-off-by: a1012112796 <[email protected]>
zeripath
approved these changes
Apr 5, 2020
GiteaBot
added
the
lgtm/need 1
zeripath
changed the title
|
Coming up with a succinct title for this PR is remarkably difficult! |
zeripath
reviewed
Apr 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #10970 +/- ##
==========================================
- Coverage 43.62% 43.60% -0.02%
==========================================
Files 597 597
Lines 83923 83923
==========================================
- Hits 36613 36597 -16
- Misses 42799 42813 +14
- Partials 4511 4513 +2
Continue to review full report at Codecov.
|
6543
requested changes
Apr 5, 2020
a1012112796
force-pushed
the
block_login_limit
branch
from
4ba455a
to
065ee36
Compare
guillep2k
approved these changes
Apr 5, 2020
GiteaBot
added
lgtm/done
6543
approved these changes
Apr 5, 2020
lafriks
approved these changes
Apr 5, 2020
|
ping LG-TM |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* ui: limit managers prohibit themself to login Because I think it's crazy and not reasonale , that if a user can prohibit themself to login. so suggest limit this choice on ui Signed-off-by: a1012112796 <[email protected]> * skip self Prohibit Login in post event handle * fix comment Co-authored-by: zeripath <[email protected]> Co-authored-by: John Olheiser <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I think it's crazy and not reasonale , that if a user can prohibit themself to login. so suggest limit this choice on ui.