Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust label padding #10957

Merged
merged 4 commits into from
Apr 4, 2020
Merged

Adjust label padding #10957

merged 4 commits into from
Apr 4, 2020

Conversation

mrsdizzie
Copy link
Member

@mrsdizzie mrsdizzie commented Apr 4, 2020

The default label padding isn't semetrical and is also a bit large, leading most labels to really look more like buttons. This adjusts the padding to make them look more like labels and feel less bulky.

old new
Screen Shot 2020-04-04 at 12 25 01 PM Screen Shot 2020-04-04 at 1 09 39 PM

The default label padding isn't semetrical and is also a bit large, leading most labels to really look more like buttons. This slightly adjusts the padding to make them look more like labels and feel less bulky.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #10957 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10957   +/-   ##
=======================================
  Coverage   43.62%   43.62%           
=======================================
  Files         597      597           
  Lines       83923    83923           
=======================================
+ Hits        36609    36614    +5     
+ Misses      42802    42798    -4     
+ Partials     4512     4511    -1     
Impacted Files Coverage Δ
modules/git/repo.go 48.11% <0.00%> (-0.42%) ⬇️
services/pull/pull.go 35.88% <0.00%> (+0.88%) ⬆️
modules/git/utils.go 70.14% <0.00%> (+4.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a06d3a...8b57403. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 4, 2020
@jolheiser
Copy link
Member

Ping LGTM

@jolheiser jolheiser merged commit a0cc4b3 into go-gitea:master Apr 4, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 5, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 5, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants