Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding directory execution on hook (#10954) #10955

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

bazilek
Copy link
Contributor

@bazilek bazilek commented Apr 4, 2020

Addressing hooks issue #10954

Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @mrsdizzie comment on the underlying issue - however, it's quite a simple test.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #10955 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10955      +/-   ##
==========================================
- Coverage   43.62%   43.61%   -0.01%     
==========================================
  Files         597      597              
  Lines       83923    83923              
==========================================
- Hits        36609    36605       -4     
- Misses      42802    42807       +5     
+ Partials     4512     4511       -1     
Impacted Files Coverage Δ
modules/repository/hooks.go 35.38% <100.00%> (ø)
modules/queue/workerpool.go 58.00% <0.00%> (-2.14%) ⬇️
services/pull/check.go 48.17% <0.00%> (-1.83%) ⬇️
models/error.go 30.49% <0.00%> (-0.54%) ⬇️
modules/git/repo.go 48.11% <0.00%> (-0.42%) ⬇️
services/pull/pull.go 35.88% <0.00%> (+0.88%) ⬆️
modules/process/manager.go 78.31% <0.00%> (+3.61%) ⬆️
modules/git/utils.go 70.14% <0.00%> (+4.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a06d3a...18f4da9. Read the comment docs.

@zeripath zeripath added the type/enhancement An improvement of existing functionality label Apr 4, 2020
@zeripath zeripath added this to the 1.12.0 milestone Apr 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 4, 2020
@jolheiser jolheiser merged commit 240258a into go-gitea:master Apr 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants