Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ActivityHeatmap to Vue SFC #10953

Merged
merged 5 commits into from
Apr 6, 2020

Conversation

gary-kim
Copy link
Member

@gary-kim gary-kim commented Apr 4, 2020

Follow up to #10188

Migrate ActivityHeatmap to use Vue SFC and compile at build time.

Signed-off-by: Gary Kim [email protected]

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Apr 4, 2020
@lunny lunny added this to the 1.12.0 milestone Apr 4, 2020
@6543
Copy link
Member

6543 commented Apr 5, 2020

@gary-kim heatmap works just fine but "dashboard-repos" are gone ?!?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 5, 2020
@6543
Copy link
Member

6543 commented Apr 5, 2020

@gary-kim heatmap works just fine but "dashboard-repos" are gone ?!?

Dont remove alias in webpack.config.js and it works all fine

@gary-kim
Copy link
Member Author

gary-kim commented Apr 5, 2020

Dont remove alias in webpack.config.js and it works all fine

Okay then. Added it back in here. At some point, I'll go through to see what's left using compile on the browser and migrate them.

@codecov-io
Copy link

codecov-io commented Apr 5, 2020

Codecov Report

Merging #10953 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10953      +/-   ##
==========================================
- Coverage   43.63%   43.60%   -0.03%     
==========================================
  Files         597      597              
  Lines       83923    83923              
==========================================
- Hits        36619    36594      -25     
- Misses      42794    42817      +23     
- Partials     4510     4512       +2     
Impacted Files Coverage Δ
services/pull/patch.go 62.93% <0.00%> (-2.80%) ⬇️
services/pull/temp_repo.go 29.05% <0.00%> (-2.57%) ⬇️
models/unit.go 41.97% <0.00%> (-2.47%) ⬇️
services/pull/check.go 50.00% <0.00%> (-2.44%) ⬇️
modules/log/event.go 64.61% <0.00%> (-1.03%) ⬇️
services/pull/pull.go 35.00% <0.00%> (-0.89%) ⬇️
routers/repo/view.go 36.14% <0.00%> (-0.68%) ⬇️
models/gpg_key.go 53.42% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f072d45...ecbaf76. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2020
@lunny
Copy link
Member

lunny commented Apr 6, 2020

make L-G-T-M work.

@lunny lunny merged commit 561e7a9 into go-gitea:master Apr 6, 2020
@gary-kim gary-kim deleted the techdebt/noid/vue-calendar-heatmap branch April 6, 2020 01:46
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants