-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cross compile #10952
Merged
Merged
Fix cross compile #10952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
label
Apr 4, 2020
plz resolve conflict :) |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 4, 2020
lunny
force-pushed
the
lunny/cross_compile
branch
from
April 5, 2020 03:50
9e73d05
to
3a493b1
Compare
7 tasks
6543
approved these changes
Apr 5, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Apr 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #10952 +/- ##
==========================================
+ Coverage 43.60% 43.63% +0.03%
==========================================
Files 597 597
Lines 83923 83923
==========================================
+ Hits 36593 36619 +26
+ Misses 42816 42794 -22
+ Partials 4514 4510 -4
Continue to review full report at Codecov.
|
zeripath
approved these changes
Apr 5, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 5, 2020
Ping |
everhopingandwaiting
pushed a commit
to everhopingandwaiting/gitea
that referenced
this pull request
Apr 6, 2020
* Fix cross compile * Add test for cross compile * Fix drone * Fix drone * Also prevent CC environment not to generate Co-authored-by: zeripath <[email protected]>
lafriks
pushed a commit
that referenced
this pull request
Apr 8, 2020
… merge white list (#10951) * [suggest] change merge strategy: do not check write access if user in merge white list #10935 (cherry picked from commit ba74fc6389dfcad03c273441a49b54e4d38c86ee) * fix NPE * Fix cross compile (#10952) * Fix cross compile * Add test for cross compile * Fix drone * Fix drone * Also prevent CC environment not to generate Co-authored-by: zeripath <[email protected]> * fix merge box icon color bug (#10974) that because need some space beturn ``text`` and color defines Signed-off-by: a1012112796 <[email protected]> * [skip ci] Updated translations via Crowdin * Allow X in addition to x in tasks (#10979) Signed-off-by: Andrew Thornton <[email protected]> * remove api: merge reqRepoWriter Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: 赵智超 <[email protected]> Co-authored-by: GiteaBot <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: guillep2k <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
… merge white list (go-gitea#10951) * [suggest] change merge strategy: do not check write access if user in merge white list go-gitea#10935 (cherry picked from commit ba74fc6389dfcad03c273441a49b54e4d38c86ee) * fix NPE * Fix cross compile (go-gitea#10952) * Fix cross compile * Add test for cross compile * Fix drone * Fix drone * Also prevent CC environment not to generate Co-authored-by: zeripath <[email protected]> * fix merge box icon color bug (go-gitea#10974) that because need some space beturn ``text`` and color defines Signed-off-by: a1012112796 <[email protected]> * [skip ci] Updated translations via Crowdin * Allow X in addition to x in tasks (go-gitea#10979) Signed-off-by: Andrew Thornton <[email protected]> * remove api: merge reqRepoWriter Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: 赵智超 <[email protected]> Co-authored-by: GiteaBot <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: guillep2k <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10949, #10950
Now we can use
TAGS=bindata GOOS=linux GOARCH=arm64 make build
to cross compile.