Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: change time-line event icons tyle #10940

Closed
wants to merge 1 commit into from

Conversation

a1012112796
Copy link
Member

Co-authored-by: Sorien [email protected]

  • change icons style on time-line to a more meaningfull icon like github instead of primitive-dot

  • change merge comment style to distinguish it from close

view:
js1


js2


js3


js4


js5

Close #10864

* Fix timeline icons offset go-gitea#10864
Co-authored-by: Sorien <[email protected]>
* change icons style on time-line to a more meaningfull icon like github instead of  primitive-dot
* change merge comment style to distinguish it from close

Signed-off-by: a1012112796 <[email protected]>
@Sorien
Copy link
Contributor

Sorien commented Apr 3, 2020

personally i'd try to align icon and avatar together

could you try

.issue-symbol {
    float: left;
    width: 30px;
    height: 30px;
    background-color: #eee;
    border: 2px solid #fff;
    margin-left: -36px;
    border-radius: 50%;
    padding: 5px;
}

and change all svg icons to theirs original width & height of 16px

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 3, 2020
@mrsdizzie
Copy link
Member

Maybe beyond the scope of this PR, but it would also be nice if the avatar was on the other side of the time line for review comments or approvals, like on Github:

Screen Shot 2020-04-03 at 12 55 18 PM

@guillep2k guillep2k added the topic/ui Change the appearance of the Gitea UI label Apr 4, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone Apr 4, 2020
@a1012112796
Copy link
Member Author

Maybe beyond the scope of this PR, but it would also be nice if the avatar was on the other side of the time line for review comments or approvals, like on Github:

Screen Shot 2020-04-03 at 12 55 18 PM

Yes, and it's same size and position with comment , I will check and try it. Thanks

@Sorien
Copy link
Contributor

Sorien commented Apr 4, 2020

@a1012112796 finally i'm able to build gittea from sources, could you give me few days i'll try to come with proper solution

@a1012112796
Copy link
Member Author

@a1012112796 finally i'm able to build gittea from sources, could you give me few days i'll try to come with proper solution

That's fun, Thanks!

@a1012112796
Copy link
Member Author

Close this PR, It's duplicate #10972, Let's wait it.
@guillep2k Please remove this PR from Milestone.

@a1012112796 a1012112796 closed this Apr 6, 2020
@zeripath zeripath removed this from the 1.12.0 milestone Apr 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@a1012112796 a1012112796 deleted the fix_timeline branch June 24, 2022 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] make more icon types onto the time-line like github
6 participants