Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API to get single commit via SHA and Ref #10915

Merged
merged 12 commits into from
Apr 8, 2020
+171 −32
Merged

API to get single commit via SHA and Ref #10915

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d3bb560
GET /repos/:owner/:repo/commits/:ref
6543 Apr 1, 2020
5b72c19
add Validation Checks
6543 Apr 5, 2020
c6c66e9
Fix & Extend TEST
6543 Apr 5, 2020
6527718
add two new tast cases
6543 Apr 5, 2020
22007c8
Merge branch 'master' into 10089-api-single-commit
6543 Apr 5, 2020
a8d5dda
Merge branch 'master' into 10089-api-single-commit
6543 Apr 6, 2020
3b27de4
Merge branch 'master' into 10089-api-single-commit
6543 Apr 6, 2020
ff7b667
Merge branch 'master' into 10089-api-single-commit
6543 Apr 6, 2020
ad34818
Merge branch 'master' into 10089-api-single-commit
6543 Apr 6, 2020
8e47d9e
Merge branch 'master' into 10089-api-single-commit
6543 Apr 6, 2020
9d85db4
Merge branch 'master' into 10089-api-single-commit
6543 Apr 7, 2020
52ce2dc
Merge branch 'master' into 10089-api-single-commit
6543 Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix & Extend TEST
  • Loading branch information
@6543
6543 committed Apr 5, 2020
commit c6c66e95af56f211ab1e404b3698dde77ab77864
38 changes: 30 additions & 8 deletions integrations/api_repo_git_commits_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,39 @@ func TestAPIReposGitCommits(t *testing.T) {
session := loginUser(t, user.Name)
token := getTokenForLoggedInUser(t, session)

//check invalid requests for GetCommitsBySHA
req := NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/git/commits/master?token="+token, user.Name)
session.MakeRequest(t, req, http.StatusUnprocessableEntity)

req = NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/git/commits/12345?token="+token, user.Name)
session.MakeRequest(t, req, http.StatusNotFound)

//check invalid requests for GetCommitsByRef
req = NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/commits/..?token="+token, user.Name)
session.MakeRequest(t, req, http.StatusUnprocessableEntity)

req = NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/commits/branch-not-exist?token="+token, user.Name)
session.MakeRequest(t, req, http.StatusNotFound)

for _, ref := range [...]string{
"commits/master", // Branch
"commits/v1.1", // Tag
"master", // Branch
"v1.1", // Tag
} {
req := NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/git/%s?token="+token, user.Name, ref)
session.MakeRequest(t, req, http.StatusOK)
req = NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/commits/%s?token="+token, user.Name, ref)
resp := session.MakeRequest(t, req, http.StatusOK)
commitByRef := new(api.Commit)
DecodeJSON(t, resp, commitByRef)
assert.Len(t, commitByRef.SHA, 40)
assert.EqualValues(t, commitByRef.SHA, commitByRef.RepoCommit.Tree.SHA)
req = NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/git/commits/%s?token="+token, user.Name, commitByRef.SHA)
resp = session.MakeRequest(t, req, http.StatusOK)
commitBySHA := new(api.Commit)
DecodeJSON(t, resp, commitBySHA)

assert.EqualValues(t, commitByRef.SHA, commitBySHA.SHA)
assert.EqualValues(t, commitByRef.HTMLURL, commitBySHA.HTMLURL)
assert.EqualValues(t, commitByRef.RepoCommit.Message, commitBySHA.RepoCommit.Message)
}

// Test getting non-existent refs
req := NewRequestf(t, "GET", "/api/v1/repos/%s/repo1/git/commits/unknown?token="+token, user.Name)
session.MakeRequest(t, req, http.StatusNotFound)
}

func TestAPIReposGitCommitList(t *testing.T) {
Expand Down