Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of issues.closed_by to list opening user first #10876

Merged
merged 3 commits into from
Mar 29, 2020

Conversation

zeripath
Copy link
Contributor

The simplest fix for the confusing closed x minutes ago by opening_user problem is to rearrange the order of the issues.closed_by string to by opening_user closed x minutes ago

Fix #8266

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added this to the 1.12.0 milestone Mar 29, 2020
@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #10876 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10876      +/-   ##
==========================================
+ Coverage   43.40%   43.43%   +0.02%     
==========================================
  Files         593      593              
  Lines       83286    83286              
==========================================
+ Hits        36154    36178      +24     
+ Misses      42640    42620      -20     
+ Partials     4492     4488       -4     
Impacted Files Coverage Δ
services/pull/patch.go 64.51% <0.00%> (-0.65%) ⬇️
routers/repo/view.go 36.82% <0.00%> (+0.67%) ⬆️
modules/git/repo.go 48.11% <0.00%> (+0.83%) ⬆️
modules/queue/workerpool.go 58.00% <0.00%> (+1.06%) ⬆️
services/pull/pull.go 35.88% <0.00%> (+1.17%) ⬆️
services/pull/temp_repo.go 31.62% <0.00%> (+2.56%) ⬆️
modules/git/utils.go 70.14% <0.00%> (+4.47%) ⬆️
modules/indexer/stats/db.go 50.00% <0.00%> (+9.37%) ⬆️
modules/indexer/stats/queue.go 81.25% <0.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209045f...7caed7f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2020
@guillep2k guillep2k merged commit 20d4f92 into go-gitea:master Mar 29, 2020
@zeripath zeripath deleted the fix-8266-issues-list-closed-by branch March 29, 2020 16:46
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closed Issues show wrong user information
7 participants