Avoid logging []byte in queue failures - convert to string first

[zeripath]

Whilst debugging an issue on discord I noticed that we were logging:

2020/03/28 18:14:47 ...eue/queue_wrapped.go:161:Run() [F] Unable to set the internal queue for -wrapper Error: Unable to create queue level for  with cfg [123 ... 125] by max attempts: error: file missing [file=MANIFEST-000000]

because the cfg is possibly being passed as a []byte to log/fmt.Errorf. The solution is to check if the config is a []byte and if so cast it to a string before logging.

Signed-off-by: Andrew Thornton [email protected]

[codecov-io]

Codecov Report

Merging #10865 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #10865      +/-   ##
==========================================
+ Coverage   43.40%   43.41%   +0.01%     
==========================================
  Files         593      593              
  Lines       83271    83276       +5     
==========================================
+ Hits        36140    36154      +14     
+ Misses      42640    42636       -4     
+ Partials     4491     4486       -5     

Impacted Files	Coverage Δ
modules/queue/queue_wrapped.go	6.28% <0.00%> (-0.19%)	⬇️
models/notification.go	63.88% <0.00%> (-0.84%)	⬇️
modules/queue/workerpool.go	58.00% <0.00%> (+1.06%)	⬆️
modules/git/repo.go	48.53% <0.00%> (+1.25%)	⬆️
modules/process/manager.go	78.31% <0.00%> (+3.61%)	⬆️
modules/indexer/stats/db.go	59.37% <0.00%> (+18.75%)	⬆️
modules/indexer/stats/queue.go	81.25% <0.00%> (+18.75%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea67e56...ae06185. Read the comment docs.

[lunny]

make L-G-T-M