Add 'make lint', restructure 'compliance' pipeline #10861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
silverwind
commented
Mar 28, 2020
•
silverwind
commented
- Added 'lint', 'lint-frontend', 'lint-backend' targets
- Added 'lint-frontend', 'lint-backend' ci steps and restructure the 'compliance' pipeline to have a clear separation between frontend and backend and use parallelism where possible. Also, the main build pipelines now depend on 'compliance' so they will skip if it fails.
- Added dependencies on ci steps so they skip when 'compliance' fails
- Moved JS linters to devDependencies
- Removed deprecated 'js' and 'css' targets
silverwind
force-pushed
the
lint
branch
2 times, most recently
from
4b3a3be
to
124dde6
Compare
silverwind
changed the title
|
Should be ready for review. |
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #10861 +/- ##
==========================================
+ Coverage 43.39% 43.41% +0.01%
==========================================
Files 593 593
Lines 83285 83285
==========================================
+ Hits 36141 36157 +16
+ Misses 42650 42637 -13
+ Partials 4494 4491 -3
Continue to review full report at Codecov.
|
zeripath
approved these changes
Mar 28, 2020
GiteaBot
added
lgtm/need 1
zeripath
added
the
topic/build
silverwind
force-pushed
the
lint
branch
2 times, most recently
from
f7fd128
to
516117f
Compare
6543
approved these changes
Mar 29, 2020
GiteaBot
added
lgtm/done
|
by by |
- Added 'lint', 'lint-frontend', 'lint-backend' targets - Added 'lint-frontend', 'lint-backend' ci steps and restructure the 'compliance' pipeline to have a clear separation between frontend and backend and use parallelism where possible. Also, the main build pipelines now depend on 'compliance' so they will skip if it fails. - Added dependencies on ci steps so they skip when 'compliance' fails - Moved JS linters to devDependencies - Removed deprecated 'js' and 'css' targets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.