Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MySQL rowtype to dynamic for new tables #10833

Merged
merged 3 commits into from
Mar 27, 2020

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Mar 26, 2020

Fixes #9347 for new installations and new tables

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Mar 26, 2020
@lafriks lafriks added this to the 1.12.0 milestone Mar 26, 2020
models/models.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 26, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 26, 2020
@codecov-io
Copy link

Codecov Report

Merging #10833 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10833      +/-   ##
==========================================
- Coverage   43.56%   43.54%   -0.02%     
==========================================
  Files         589      589              
  Lines       82691    82694       +3     
==========================================
- Hits        36023    36008      -15     
- Misses      42192    42208      +16     
- Partials     4476     4478       +2     
Impacted Files Coverage Δ
models/models.go 60.22% <100.00%> (+0.67%) ⬆️
modules/git/utils.go 65.67% <0.00%> (-4.48%) ⬇️
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
models/unit.go 41.97% <0.00%> (-2.47%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
modules/git/repo.go 46.78% <0.00%> (-0.92%) ⬇️
services/pull/pull.go 35.00% <0.00%> (-0.89%) ⬇️
models/notification.go 63.88% <0.00%> (-0.84%) ⬇️
routers/repo/view.go 36.14% <0.00%> (-0.68%) ⬇️
modules/indexer/stats/db.go 50.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c331c...cfe14a0. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 26, 2020
@zeripath
Copy link
Contributor

@lafriks would it be worth just writing a migration so we never have to hear about this or get blamed for this again?

@guillep2k
Copy link
Member

There's a chance this setting is also required?:

SET GLOBAL innodb_file_format=barracuda

See SO.

It may depend on the engine version.

@lunny
Copy link
Member

lunny commented Mar 27, 2020

@zeripath We don't need a migration. Once user encountered this problem, it will install gitea failed.

@lafriks
Copy link
Member Author

lafriks commented Mar 27, 2020

@guillep2k this needs to be implemented first as param in xorm like it is with rowtype

@lafriks lafriks merged commit a3f9094 into go-gitea:master Mar 27, 2020
@lafriks lafriks deleted the feat/set_mysql_params branch March 27, 2020 08:44
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORM engine initialization Error: migrate: Row size too large
6 participants