Document Makefile requiring dev NODE_ENV #10761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this'll be temporary, or even rejected over a better solution. To quickly summarise: Some npm devDependencies are required for the frontend build steps. Longer explanation: Due to some dependencies, like `webpack-cli` for example, being required to build the project whilst still being in the devDependencies of the `package.json` file, the project fails to build if someone has their default NODE_ENV set to production instead of development. As of writing this, if NODE_ENV is set to production, eslint fails first, due to at least missing `eslint-config-airbnb-base`. Then webpack fails due to missing webpack-cli. Then stylelint fails. And lastly, postcss is missing.
|
|
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 18, 2020
- move all JS build dependencies to 'dependencies' - update all JS dependencies Reason for this is that npm will only install 'dependencies' when under the effect of NODE_ENV=production which may be present on some build systems. Linters currently need to be depdendencies because we run linting as part of the build step, but I plan to move them to a separate 'lint' target which means they can move to devDependencies then. Fixes: go-gitea#10761
|
Fix for this in #10763. |
lunny
pushed a commit
that referenced
this pull request
Mar 19, 2020
- move all JS build dependencies to 'dependencies' - update all JS dependencies Reason for this is that npm will only install 'dependencies' when under the effect of NODE_ENV=production which may be present on some build systems. Linters currently need to be depdendencies because we run linting as part of the build step, but I plan to move them to a separate 'lint' target which means they can move to devDependencies then. Fixes: #10761
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this'll be temporary, or even rejected over a better solution. To quickly summarize: Some npm devDependencies are required for the frontend build steps, and it doesn't seem to be documented that development node environment is required in order for make to work.
Longer explanation:
Due to some dependencies, like
webpack-clifor example, being required to build the project whilst still being in the devDependencies of thepackage.jsonfile, the project fails to build if someone has their default NODE_ENV set to production instead of development.As of writing this, if NODE_ENV is set to production, eslint fails first, due to at least missing
eslint-config-airbnb-base. Then webpack fails due to missing webpack-cli. Then stylelint fails. And lastly, postcss is missing.