Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "show more repos" to extend the repo list #10674

Closed
wants to merge 1 commit into from

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Mar 8, 2020

Replaces #8230

image

image

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Mar 8, 2020
@lafriks lafriks added this to the 1.12.0 milestone Mar 8, 2020
@zeripath
Copy link
Contributor

zeripath commented Mar 8, 2020

I think paging would be better, the repo list could be very very large indeed.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2020
@lafriks
Copy link
Member Author

lafriks commented Mar 9, 2020

I don't think paging would best option here as this is more for fast access to repos not for browsing

@silverwind
Copy link
Member

silverwind commented Mar 9, 2020

Maybe just always extend it to the whole rendered page height? Extra scrollbars seem unneccesary given that there is almost always space.

@silverwind
Copy link
Member

I also have a UX concern. Say my mouse is over the repo list but my intention is to scroll the whole page. Now I'd be inadvertently scrolling the repo list.

@lafriks
Copy link
Member Author

lafriks commented Mar 9, 2020

@silverwind this is tricky from UX point in both ways :) If you do not add scrollbar you will always have to scroll up to access tabs, search box etc

@stale
Copy link

stale bot commented May 9, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label May 9, 2020
@davydov-vyacheslav
Copy link

unstale (?)

@stale stale bot removed the issue/stale label May 9, 2020
@zeripath
Copy link
Contributor

zeripath commented May 9, 2020

Obsoleted by #11321

@lafriks lafriks closed this May 16, 2020
@lafriks lafriks deleted the feat/more_repos branch May 16, 2020 20:05
@lafriks lafriks modified the milestones: 1.12.0, 1.11.6 May 16, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants