Fix tab indentation in code view

[cipherboy]

Resolves: #5596

Signed-off-by: Alexander Scheel <[email protected]>

---

On my system (F31, Firefox 73), this almost works. It does move the code over by one character, without having the prefixed space affect the tab indentation. The issue is that Firefox can't seem to correctly calculate the offset of the size of 8 spaces in the selected font (Liberation Mono).

See attached screenshots:

When this font is disabled, it does work:

We can probably leave the width as-is, I just updated it to keep the same original width.

[codecov-io]

Codecov Report

Merging #10671 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10671      +/-   ##
==========================================
+ Coverage    43.6%   43.61%   +0.01%     
==========================================
  Files         588      588              
  Lines       82485    82485              
==========================================
+ Hits        35965    35974       +9     
+ Misses      42059    42048      -11     
- Partials     4461     4463       +2

Impacted Files	Coverage Δ
modules/indexer/stats/db.go	50% <0%> (-9.38%)	⬇️
modules/queue/unique_queue_disk_channel.go	53.84% <0%> (-1.93%)	⬇️
modules/queue/workerpool.go	56.93% <0%> (-1.07%)	⬇️
services/pull/pull.go	35% <0%> (-0.89%)	⬇️
modules/repofiles/update.go	38.69% <0%> (-0.39%)	⬇️
modules/setting/git.go	65.38% <0%> (ø)	⬆️
routers/private/hook.go	36.6% <0%> (ø)	⬆️
models/error.go	29.23% <0%> (+0.51%)	⬆️
models/notification.go	64.71% <0%> (+0.83%)	⬆️
models/unit.go	39.5% <0%> (+2.46%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4901096...eb09077. Read the comment docs.

[cipherboy]

FWIW, I can reproduce the font rendering issue in Firefox when viewing the raw file. So, this is a Firefox/Linux/Liberation Mono bug. This PR can continue.

[zeripath]

In which case we should remove Liberation Mono from the suggested fonts I think.

[6543]

all in all - I like the change of this pull

[cipherboy]

@zeripath said:

In which case we should remove Liberation Mono from the suggested fonts I think.

I've filed a Firefox bug about it. I've tried two different versions of Liberation Mono from Fedora and they both seem to have this problem. There's also a historical Fedora bug, but that's been marked as resolved and I can't reproduce this issue in gedit or Chromium. It seems to only be a Firefox problem for some reason.

I'd prefer to leave it in the list for now. I think Liberation Mono is a fairly common font on Linux systems.

[zeripath]

make lg-tm work

[cipherboy]

Thanks for the merge!