Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc JS linting and naming tweaks #10652

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Misc JS linting and naming tweaks #10652

merged 2 commits into from
Mar 11, 2020

Conversation

silverwind
Copy link
Member

  • lowercase all js filenames except Vue components
  • enable new lint rules, mostly focused on shorter code
  • autofix new lint violations
  • apply misc transformations indexOf -> includes and onevent-> addEventListener

lafriks
lafriks reviewed Mar 8, 2020
View reviewed changes
webpack.config.js Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2020
@silverwind
Misc JS linting and naming tweaks
8fccae2 
- lowercase all js filenames except Vue components
- enable new lint rules, mostly focused on shorter code
- autofix new lint violations
- apply misc transformations indexOf -> includes and onevent-> addEventListener
@silverwind
Copy link
Member Author

rebased

@codecov-io
Copy link

Codecov Report

Merging #10652 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10652      +/-   ##
==========================================
+ Coverage   43.57%   43.62%   +0.04%     
==========================================
  Files         588      588              
  Lines       82490    82490              
==========================================
+ Hits        35949    35984      +35     
+ Misses      42087    42047      -40     
- Partials     4454     4459       +5
Impacted Files Coverage Δ
modules/git/command.go 86.95% <0%> (-2.61%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/notification.go 63.88% <0%> (-0.84%) ⬇️
models/gpg_key.go 53.42% <0%> (-0.53%) ⬇️
services/pull/pull.go 34.7% <0%> (-0.3%) ⬇️
models/pull.go 42.85% <0%> (+0.55%) ⬆️
modules/git/repo.go 47.7% <0%> (+0.91%) ⬆️
services/pull/temp_repo.go 31.62% <0%> (+2.56%) ⬆️
services/pull/patch.go 64.51% <0%> (+2.58%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8551f8...8fccae2. Read the comment docs.

@lafriks lafriks added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 8, 2020
@lafriks lafriks added this to the 1.12.0 milestone Mar 8, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 8, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 11, 2020
@lafriks
Copy link
Member

lafriks commented Mar 11, 2020

Make lgtm work

@lafriks lafriks merged commit e03d627 into go-gitea:master Mar 11, 2020
@silverwind silverwind deleted the misc-tweaks branch March 11, 2020 21:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @codecov-io @lafriks @sapk @GiteaBot