Fix webhook migration #10641
Merged
Fix webhook migration #10641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <[email protected]>
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Mar 6, 2020
GiteaBot
added
lgtm/done
lafriks
added
the
issue/critical
zeripath
approved these changes
Mar 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should correct the granular webhook migration. It also tidies up the migration to make it easier to compare to the models structs.
I think the biggest things to note are
HookEventfor each loop, as otherwise I think re-using it can cause muddied data.Proof of concept on why it was failing before: https://play.golang.org/p/_L6VYgQsn1a