Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Update button is enabled even when CI has failed #10640

Merged
merged 5 commits into from
Mar 7, 2020
Merged

Ensure Update button is enabled even when CI has failed #10640

merged 5 commits into from
Mar 7, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 6, 2020 •
edited

as title

fix #10637

@6543 6543 changed the title Update Pull Button: ignore status [WIP] Update Pull Button: ignore status Mar 6, 2020
@6543
Copy link
Member Author

6543 commented Mar 6, 2020

look:

As admin:

Bildschirmfoto zu 2020-03-06 19-21-25

As write access user:

Bildschirmfoto zu 2020-03-06 19-21-43

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 6, 2020
@6543 6543 changed the title [WIP] Update Pull Button: ignore status Update Pull Button: ignore status Mar 6, 2020
@6543
Copy link
Member Author

6543 commented Mar 6, 2020

@silverwind you may have a look at the CSS part? ;)

@zeripath zeripath changed the title Update Pull Button: ignore status Ensure Update button is enabled even when CI has failed Mar 6, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 7, 2020
@lafriks lafriks merged commit 57c7a7a into go-gitea:master Mar 7, 2020
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Mar 7, 2020
@lafriks lafriks added this to the 1.12.0 milestone Mar 7, 2020
@6543 6543 deleted the update-pull-ignore-status branch March 7, 2020 01:27
@silverwind
Copy link
Member

silverwind commented Mar 7, 2020 •
edited

That's not something I can review easily. One suggestion is to stick to quarters (.25, .5, .75, 1, ...) of rem units unless pixel-perfect positioning is needed, at which point px is probably the better choice.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Enhancement: UI: update-branch button usable if status-check is not success
6 participants
@6543 @silverwind @zeripath @guillep2k @lafriks @GiteaBot