Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure executable bit is kept on the web editor #10607

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Ensure executable bit is kept on the web editor #10607

merged 2 commits into from
Mar 4, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 4, 2020

When editing a file with the editor - if the file had an executable bit keep it set.

Fix #7771

@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 4, 2020
@zeripath zeripath added this to the 1.12.0 milestone Mar 4, 2020
@lafriks lafriks added type/enhancement An improvement of existing functionality type/bug and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/enhancement An improvement of existing functionality labels Mar 4, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2020
@sapk sapk merged commit 4e65d2b into go-gitea:master Mar 4, 2020
@guillep2k guillep2k mentioned this pull request Mar 5, 2020
Closed
7 tasks
@lafriks
Copy link
Member

lafriks commented Mar 5, 2020

I think this could be backported

@zeripath zeripath deleted the keep-executable-bit-in-editor branch March 5, 2020 07:06
zeripath pushed a commit to zeripath/gitea that referenced this pull request Mar 5, 2020
@sapk @zeripath
Ensure executable bit is kept on the web editor (go-gitea#10607)
d8539ee 
Co-authored-by: Antoine GIRARD <[email protected]>
@zeripath zeripath mentioned this pull request Mar 5, 2020
Merged
lunny added a commit that referenced this pull request Mar 5, 2020
@lunny @sapk
Ensure executable bit is kept on the web editor (#10607) (#10614)
fd85d31 
Co-authored-by: Antoine GIRARD <[email protected]>

Co-authored-by: Antoine GIRARD <[email protected]>
@lafriks lafriks added the backport/done All backports for this PR have been created label Mar 5, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@sapk sapk sapk approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

File looses executable bit after editing through web interface
5 participants
@zeripath @lafriks @sapk @guillep2k @GiteaBot