Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update templates for Go 1.14 #10596

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Update templates for Go 1.14 #10596

merged 2 commits into from
Mar 4, 2020

Conversation

jolheiser
Copy link
Member

Related to #10467

@jolheiser
Fix templates
ddd417d 
Signed-off-by: jolheiser <[email protected]>
@jolheiser jolheiser added the topic/ui Change the appearance of the Gitea UI label Mar 4, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone Mar 4, 2020
techknowlogick
techknowlogick approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 ty

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 4, 2020
@codecov-io
Copy link

codecov-io commented Mar 4, 2020 •
edited
Loading

Codecov Report

Merging #10596 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10596      +/-   ##
==========================================
- Coverage   43.71%    43.7%   -0.01%     
==========================================
  Files         585      585              
  Lines       82031    82031              
==========================================
- Hits        35858    35855       -3     
- Misses      41731    41738       +7     
+ Partials     4442     4438       -4
Impacted Files Coverage Δ
services/pull/check.go 50% <0%> (-0.61%) ⬇️
services/pull/patch.go 61.93% <0%> (-2.59%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
routers/repo/view.go 36.14% <0%> (-0.68%) ⬇️
modules/indexer/stats/db.go 50% <0%> (ø) ⬆️
models/error.go 29.23% <0%> (+0.51%) ⬆️
services/pull/pull.go 35.88% <0%> (+0.88%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd417d...bd2c1ad. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2020
@jolheiser jolheiser added type/bug and removed topic/ui Change the appearance of the Gitea UI labels Mar 4, 2020
@lafriks lafriks merged commit afa1e1a into go-gitea:master Mar 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jolheiser @codecov-io @techknowlogick @guillep2k @lafriks @GiteaBot