Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yandex OAuth2 provider (#8335) #10564

Merged
merged 12 commits into from
Mar 4, 2020

Conversation

anatolym
Copy link

@anatolym anatolym commented Mar 2, 2020

Fix #8335

Screen Shot 2020-03-01 at 17 55 32

@guillep2k guillep2k added the type/enhancement An improvement of existing functionality label Mar 2, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone Mar 2, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 2, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2020
@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #10564 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10564      +/-   ##
==========================================
- Coverage   43.72%   43.71%   -0.01%     
==========================================
  Files         585      585              
  Lines       82029    82034       +5     
==========================================
- Hits        35866    35864       -2     
- Misses      41723    41734      +11     
+ Partials     4440     4436       -4
Impacted Files Coverage Δ
modules/lfs/server.go 44.6% <0%> (-0.55%) ⬇️
services/pull/check.go 50% <0%> (-3.66%) ⬇️
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
modules/git/command.go 86.95% <0%> (-2.61%) ⬇️
services/pull/patch.go 61.93% <0%> (-2.59%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
models/notification.go 63.88% <0%> (-0.84%) ⬇️
routers/repo/view.go 36.14% <0%> (-0.68%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e3764...f023c9c. Read the comment docs.

@anatolym
Copy link
Author

anatolym commented Mar 3, 2020

Looks like some stuff keeps failing. Is it something I should address?

@techknowlogick
Copy link
Member

Seems when I resolved conflicts I didn't do it in a way that was go fmt capable, could you run make fmt?

templates/admin/auth/new.tmpl Outdated Show resolved Hide resolved
modules/auth/oauth2/oauth2.go Outdated Show resolved Hide resolved
@anatolym anatolym requested a review from lafriks March 3, 2020 21:09
@lafriks
Copy link
Member

lafriks commented Mar 4, 2020

Looks good now

@lafriks lafriks merged commit 3d5d211 into go-gitea:master Mar 4, 2020
@anatolym anatolym deleted the feature/add-yandex-oauth2-provider branch March 5, 2020 01:37
@zeripath zeripath changed the title OAuth2: add Yandex provider (#8335) Add Yandex OAuth2 provider (#8335) May 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] add Yandex as oauth2 support
8 participants