Implement basic global webhooks from config #10545
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a very primitive way of having webhooks configured that work for all repositories across the system. Originally I misinterpreted
Default Webhooks
as system-wide setting for this feature, and not just a template for new repositories - Doh 🤦♂The rationale for this change (as potentally hinted here) would be to enable more custom integrations. I was investigating at creating a custom authentication layer for a Docker registry, but wanted to know when a repository was deleted in order to remove images automatically. I was also looking at creating a utility to comment Jira tickets on PRs - equally in need of knowing events happening on the system.
I accept if this isn't a desired method, so alternatively we could look at implenting system webhooks in the UI and DB (while trying to avoid any confusion with default webhooks) or even a full 'apps/plugin API'? I'm also not that fluent at Go, so all comments are welcome! 😄