Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle panic in indexer initialisation better #10534

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

zeripath
Copy link
Contributor

Related #10494

@codecov-io
Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #10534 into master will increase coverage by <.01%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10534      +/-   ##
==========================================
+ Coverage   43.68%   43.69%   +<.01%     
==========================================
  Files         586      586              
  Lines       81521    81538      +17     
==========================================
+ Hits        35612    35626      +14     
- Misses      41494    41497       +3     
  Partials     4415     4415
Impacted Files Coverage Δ
modules/indexer/code/indexer.go 38.02% <10%> (-4.6%) ⬇️
modules/indexer/issues/indexer.go 57.52% <14.28%> (-0.02%) ⬇️
modules/indexer/stats/queue.go 62.5% <0%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0%> (-9.38%) ⬇️
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
modules/git/repo.go 46.78% <0%> (-0.92%) ⬇️
models/error.go 29.23% <0%> (+0.51%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.76% <0%> (+1.92%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2059a...6344806. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2020
@lunny lunny added the type/bug label Feb 28, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 28, 2020
@zeripath zeripath merged commit c32f3da into go-gitea:master Feb 28, 2020
@zeripath zeripath deleted the handle-panic-in-indexer-better branch February 28, 2020 22:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants