Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax sanitization as per https://github.com/jch/html-pipeline #10527

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

zeripath
Copy link
Contributor

Looking at github/markup#245 it is clear that GH uses https://github.com/jch/html-pipeline to sanitize. This PR relaxes our sanitization to more closely match this.

Fixes #10471
and likely others...

@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 28, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 28, 2020
@zeripath zeripath changed the title Relax sanitization as per https://github.com/jch/html-pipeline WIP: Relax sanitization as per https://github.com/jch/html-pipeline Feb 28, 2020
@zeripath zeripath changed the title WIP: Relax sanitization as per https://github.com/jch/html-pipeline Relax sanitization as per https://github.com/jch/html-pipeline Feb 28, 2020
@codecov-io
Copy link

Codecov Report

Merging #10527 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10527      +/-   ##
==========================================
+ Coverage   43.69%    43.7%   +0.01%     
==========================================
  Files         586      586              
  Lines       81521    81553      +32     
==========================================
+ Hits        35617    35642      +25     
- Misses      41491    41495       +4     
- Partials     4413     4416       +3
Impacted Files Coverage Δ
modules/markup/sanitizer.go 92.2% <100%> (+5.54%) ⬆️
modules/indexer/stats/queue.go 62.5% <0%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0%> (-9.38%) ⬇️
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
services/pull/pull.go 34.89% <0%> (-1.18%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
modules/git/repo.go 46.78% <0%> (-0.92%) ⬇️
services/pull/check.go 52.43% <0%> (+2.43%) ⬆️
services/pull/patch.go 62.89% <0%> (+2.51%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694f446...0112944. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2020
@alexanderadam
Copy link

You are awesome, @zeripath! 🙏

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2020
@zeripath
Copy link
Contributor Author

make lg-tm work

@zeripath zeripath merged commit 154b137 into go-gitea:master Feb 28, 2020
@zeripath zeripath deleted the relax-sanitization branch February 28, 2020 20:05
@lafriks lafriks mentioned this pull request Mar 15, 2020
9 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML sanitizer doesn't allow centering of text
6 participants