Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goldmark v1.1.19 -> v1.1.23 #10519

Merged
merged 4 commits into from
Feb 28, 2020
Merged

goldmark v1.1.19 -> v1.1.23 #10519

merged 4 commits into from
Feb 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 28, 2020

vendor update ...

@codecov-io
Copy link

codecov-io commented Feb 28, 2020 •
edited
Loading

Codecov Report

Merging #10519 into master will increase coverage by 0.03%.
The diff coverage is 61.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10519      +/-   ##
==========================================
+ Coverage   43.68%   43.71%   +0.03%     
==========================================
  Files         586      586              
  Lines       81475    81521      +46     
==========================================
+ Hits        35593    35639      +46     
- Misses      41470    41472       +2     
+ Partials     4412     4410       -2
Impacted Files Coverage Δ
modules/setting/setting.go 44.07% <ø> (ø) ⬆️
modules/lfs/server.go 45.14% <0%> (-0.56%) ⬇️
modules/util/compare.go 57.77% <100%> (+6.49%) ⬆️
routers/repo/issue.go 38% <100%> (ø) ⬆️
models/notification.go 64.71% <57.14%> (+0.31%) ⬆️
modules/markup/html.go 79.6% <61.53%> (-0.3%) ⬇️
models/issue.go 53.46% <64%> (-0.06%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
services/pull/check.go 53.04% <0%> (-2.44%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968d550...6399120. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 28, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 28, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2020
@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit 15c7738 into go-gitea:master Feb 28, 2020
@6543 6543 deleted the vendor-goldmark branch February 28, 2020 13:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @codecov-io @zeripath @lafriks @GiteaBot