Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #828: Embed build tags #1051

Merged
merged 5 commits into from
Feb 28, 2017
Merged

Fix for #828: Embed build tags #1051

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dafa5a4
Fix for #828
cez81 Feb 25, 2017
c6737ac
Reworked formatBuiltWith function
cez81 Feb 25, 2017
2f81c12
Add tags to version information in admin panel
cez81 Feb 27, 2017
a0cb2c0
Added new variable for use on admin page.
cez81 Feb 27, 2017
9a928c3
Fixed incorrect indentation
cez81 Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reworked formatBuiltWith function 
Signed-off-by: Jonas Östanbäck <[email protected]>
  • Loading branch information
@cez81
cez81 committed Feb 25, 2017
commit c6737aca4aa4292f1e64999d92b126d5eeaa58ff
9 changes: 5 additions & 4 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ func main() {
}

func formatBuiltWith(Tags string) string {
if len(Tags) > 0 {
return " built with: " + strings.Join(strings.Split(Tags, " "), ", ")
}
return ""
if len(Tags) == 0 {
return ""
}

return " built with: " + strings.Replace(Tags, " ", ", ", -1)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings.Join

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags is sqlite bindata form. Why use strings.Join ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but maybe it's even easier to create a comma separated list to split by space and join by comma