Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fluid-icon #10491

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Add fluid-icon #10491

merged 3 commits into from
Feb 27, 2020

Conversation

silverwind
Copy link
Member

This provides Firefox (and possible other browsers) with a high-resolution rich icon, in place of the previously removed apple-touch-icon without having to use that one as it lacks an alpha channel. This is the same method GH uses.

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/UI_considerations#Rich_icons

This provides Firefox (and possible other browsers) with a
high-resolution rich icon, in place of the previously removed
apple-touch-icon without having to use that one as it lacks an
alpha channel. This is the same method GH uses.

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/UI_considerations#Rich_icons
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 26, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Feb 26, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 26, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2020
@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #10491 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10491      +/-   ##
==========================================
+ Coverage   43.66%    43.7%   +0.04%     
==========================================
  Files         586      586              
  Lines       81408    81411       +3     
==========================================
+ Hits        35549    35583      +34     
+ Misses      41458    41424      -34     
- Partials     4401     4404       +3
Impacted Files Coverage Δ
models/user.go 49.3% <0%> (-0.13%) ⬇️
models/action.go 48.82% <0%> (-0.59%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
models/gpg_key.go 54.81% <0%> (-0.56%) ⬇️
models/pull.go 42.37% <0%> (+0.55%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
services/pull/pull.go 36.07% <0%> (+1.17%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.76% <0%> (+1.92%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be31bca...7d2a47d. Read the comment docs.

@lunny
Copy link
Member

lunny commented Feb 27, 2020

Make L-G-T-M work.

@lunny lunny merged commit 9a47611 into go-gitea:master Feb 27, 2020
@silverwind silverwind deleted the fluidicon branch February 27, 2020 07:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants