split tool versions out as variable

.drone.yml

@@ -379,7 +379,7 @@ steps:
 
  - name: static
  pull: always
- image: techknowlogick/xgo:latest
+ image: techknowlogick/xgo:go-1.14.x
  commands:
  - apt update && apt -y install curl
  - curl -sL https://deb.nodesource.com/setup_12.x | bash - && apt -y install nodejs
@@ -477,7 +477,7 @@ steps:
 
  - name: static
  pull: always
- image: techknowlogick/xgo:latest
+ image: techknowlogick/xgo:go-1.14.x
  commands:
  - apt update && apt -y install curl
  - curl -sL https://deb.nodesource.com/setup_12.x | bash - && apt -y install nodejs

Makefile

@@ -9,6 +9,10 @@ SHASUM ?= shasum -a 256
 HAS_GO = $(shell hash $(GO) > /dev/null 2>&1 && echo "GO" || echo "NOGO" )
 COMMA := ,
 
+XGO_VERSION := go-1.14.x
+MIN_GO_VERSION := 001012000
+MIN_NODE_VERSION := 010000000
+
 ifeq ($(HAS_GO), GO)
  GOPATH ?= $(shell $(GO) env GOPATH)
  export PATH := $(GOPATH)/bin:$(PATH)
@@ -145,7 +149,7 @@ help:
 .PHONY: go-check
 go-check:
  $(eval GO_VERSION := $(shell printf "%03d%03d%03d" $(shell go version | grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?[[:space:]]' | tr '.' ' ');))
- @if [ "$(GO_VERSION)" -lt "001012000" ]; then \
+ @if [ "$(GO_VERSION)" -lt "$(MIN_GO_VERSION)" ]; then \
  echo "Gitea requires Go 1.12 or greater to build. You can get it at https://golang.org/dl/"; \
  exit 1; \
  fi
@@ -161,7 +165,7 @@ git-check:
 node-check:
  $(eval NODE_VERSION := $(shell printf "%03d%03d%03d" $(shell node -v | grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?' | tr '.' ' ');))
  $(eval NPM_MISSING := $(shell hash npm > /dev/null 2>&1 || echo 1))
- @if [ "$(NODE_VERSION)" -lt "010000000" -o "$(NPM_MISSING)" = "1" ]; then \
+ @if [ "$(NODE_VERSION)" -lt "$(MIN_NODE_VERSION)" -o "$(NPM_MISSING)" = "1" ]; then \
  echo "Gitea requires Node.js 10 or greater and npm to build. You can get it at https://nodejs.org/en/download/"; \
  exit 1; \
  fi
@@ -480,7 +484,7 @@ release-windows: | $(DIST_DIRS)
  @hash xgo > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
  $(GO) get -u src.techknowlogick.com/xgo; \
  fi
- xgo -go go-1.14 -dest $(DIST)/binaries -tags 'netgo osusergo $(TAGS)' -ldflags '-linkmode external -extldflags "-static" $(LDFLAGS)' -targets 'windows/*' -out gitea-$(VERSION) .
+ xgo -go $(XGO_VERSION) -dest $(DIST)/binaries -tags 'netgo osusergo $(TAGS)' -ldflags '-linkmode external -extldflags "-static" $(LDFLAGS)' -targets 'windows/*' -out gitea-$(VERSION) .
 ifeq ($(CI),drone)
  cp /build/* $(DIST)/binaries
 endif
@@ -490,7 +494,7 @@ release-linux: | $(DIST_DIRS)
  @hash xgo > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
  $(GO) get -u src.techknowlogick.com/xgo; \
  fi
- xgo -go go-1.14 -dest $(DIST)/binaries -tags 'netgo osusergo $(TAGS)' -ldflags '-linkmode external -extldflags "-static" $(LDFLAGS)' -targets 'linux/amd64,linux/386,linux/arm-5,linux/arm-6,linux/arm64,linux/mips64le,linux/mips,linux/mipsle' -out gitea-$(VERSION) .
+ xgo -go $(XGO_VERSION) -dest $(DIST)/binaries -tags 'netgo osusergo $(TAGS)' -ldflags '-linkmode external -extldflags "-static" $(LDFLAGS)' -targets 'linux/amd64,linux/386,linux/arm-5,linux/arm-6,linux/arm64,linux/mips64le,linux/mips,linux/mipsle' -out gitea-$(VERSION) .
 ifeq ($(CI),drone)
  cp /build/* $(DIST)/binaries
 endif
@@ -500,7 +504,7 @@ release-darwin: | $(DIST_DIRS)
  @hash xgo > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
  $(GO) get -u src.techknowlogick.com/xgo; \
  fi
- xgo -go go-1.14 -dest $(DIST)/binaries -tags 'netgo osusergo $(TAGS)' -ldflags '$(LDFLAGS)' -targets 'darwin/*' -out gitea-$(VERSION) .
+ xgo -go $(XGO_VERSION) -dest $(DIST)/binaries -tags 'netgo osusergo $(TAGS)' -ldflags '$(LDFLAGS)' -targets 'darwin/*' -out gitea-$(VERSION) .
 ifeq ($(CI),drone)
  cp /build/* $(DIST)/binaries
 endif