Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max-file-size to LFS #10463

Merged
merged 6 commits into from
Feb 28, 2020
Merged

Add max-file-size to LFS #10463

merged 6 commits into from
Feb 28, 2020

Conversation

zeripath
Copy link
Contributor

Add option to app.ini to set a maximum file size to the LFS.

@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 25, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 25, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 25, 2020
zeripath
zeripath commented Feb 25, 2020
View reviewed changes
modules/lfs/server.go Outdated Show resolved Hide resolved
silverwind
silverwind reviewed Feb 25, 2020
View reviewed changes
modules/lfs/server.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 25, 2020 •
edited
Loading

Codecov Report

Merging #10463 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10463      +/-   ##
==========================================
+ Coverage   43.66%   43.66%   +<.01%     
==========================================
  Files         586      586              
  Lines       81478    81480       +2     
==========================================
+ Hits        35575    35577       +2     
  Misses      41488    41488              
  Partials     4415     4415
Impacted Files Coverage Δ
routers/repo/commit.go 29.04% <0%> (ø) ⬆️
models/action.go 48.82% <0%> (ø) ⬆️
routers/repo/attachment.go 47.57% <0%> (ø) ⬆️
modules/markup/common/linkify.go 34.69% <0%> (ø) ⬆️
models/notification.go 64.4% <0%> (ø) ⬆️
models/issue_comment.go 46.68% <100%> (+0.18%) ⬆️
models/attachment.go 57.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1cf2e2...a87b547. Read the comment docs.

@lafriks lafriks added type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 26, 2020
@6543
Copy link
Member

6543 commented Feb 27, 2020

@zeripath ping ;)

@zeripath @silverwind
As per @silverwind
5ddf3f0 
Co-Authored-By: silverwind <[email protected]>
@zeripath
Copy link
Contributor Author

Done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit 513b962 into go-gitea:master Feb 28, 2020
@zeripath zeripath deleted the lfs-limits branch February 28, 2020 10:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@guillep2k guillep2k guillep2k approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@zeripath @codecov-io @6543 @guillep2k @silverwind @lafriks @GiteaBot @lunny