Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS dependencies #10450

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Update JS dependencies #10450

merged 2 commits into from
Feb 25, 2020

Conversation

silverwind
Copy link
Member

Fomantic's update process did fail to update via 'npm install' because of our config initially but it did work after manually bumping the version in semantic.json.

Fomantic changes: https://github.com/fomantic/Fomantic-UI/blob/master/CHANGELOG.md#284

Fomantic's update process did fail to update via 'npm install' because
of our config initially but it did work after manually bumping the
version in semantic.json.

Fomantic changes:

https://github.com/fomantic/Fomantic-UI/blob/master/CHANGELOG.md#284
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Feb 24, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Feb 24, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 24, 2020
@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #10450 into master will increase coverage by <.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10450      +/-   ##
==========================================
+ Coverage   43.68%   43.69%   +<.01%     
==========================================
  Files         586      586              
  Lines       81389    81391       +2     
==========================================
+ Hits        35558    35560       +2     
+ Misses      41430    41428       -2     
- Partials     4401     4403       +2
Impacted Files Coverage Δ
models/token.go 73.77% <0%> (-6.56%) ⬇️
models/issue_watch.go 58.53% <50%> (-5.22%) ⬇️
modules/indexer/stats/queue.go 62.5% <0%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0%> (-18.75%) ⬇️
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
modules/git/repo.go 46.78% <0%> (-0.92%) ⬇️
services/pull/pull.go 35.19% <0%> (-0.88%) ⬇️
models/notification.go 64.13% <0%> (+0.84%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641b242...b58ebc7. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2020
@guillep2k guillep2k merged commit 85e6a12 into go-gitea:master Feb 25, 2020
@silverwind silverwind deleted the deps-2 branch February 25, 2020 07:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants