Show the username as a fallback on feeds if full name is blank #10438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
reviewed
Feb 24, 2020
GiteaBot
added
the
lgtm/need 2
|
To be honest I'm not really sure what the trim is there for. I guess if the user puts in a full name of just spaces we should ignore it, but surely that validation should be done at setting time? |
Codecov Report
@@ Coverage Diff @@
## master #10438 +/- ##
==========================================
- Coverage 43.69% 43.68% -0.02%
==========================================
Files 586 586
Lines 81411 81411
==========================================
- Hits 35574 35564 -10
- Misses 41430 41437 +7
- Partials 4407 4410 +3
Continue to review full report at Codecov.
|
|
@zeripath String trimming in both the user and action models are now done only if |
zeripath
approved these changes
Feb 24, 2020
GiteaBot
added
lgtm/need 1
lafriks
requested changes
Feb 24, 2020
models/action.go
Outdated
| return a.GetActFullName() | ||
| trimmedFullName := strings.TrimSpace(a.GetActFullName()) | ||
| if len(trimmedFullName) > 0 { | ||
| return a.GetActFullName() |
There was a problem hiding this comment.
Suggested change
| return a.GetActFullName() | |
| return trimmedFullName |
jamesorlakin
force-pushed
the
bugfix/feedUsernameFallback
branch
from
e4a55fa
to
a92ff62
Compare
jamesorlakin
force-pushed
the
bugfix/feedUsernameFallback
branch
2 times, most recently
from
1ff004c
to
3e6af9f
Compare
6543
approved these changes
Feb 24, 2020
GiteaBot
added
lgtm/done
jamesorlakin
force-pushed
the
bugfix/feedUsernameFallback
branch
from
3e6af9f
to
b142219
Compare
lafriks
approved these changes
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
DEFAULT_SHOW_FULL_NAMEworks well, there's a bug on the feed/dashboard page that causes the username not be used as a fallback and nothing shown instead:This PR copies the logic from
DisplayNameinmodels/user.go:741to return the username as a fallback for the template:(where
reviewis the username, andJimboas a user with the full name set)I'm happy to make a backport too. 馃槂