Add API endpoints to manage OAuth2 Application (list/create/delete) #10437

ghost · 2020-02-24T08:52:11Z

This PR adds support to create OAuth2 Applications through the API. The intention is to be able to automate the creation of application programmatically.

Maybe it is related to the issue #8764 and #9210

Tasks:

Create OAuth2 application
List existing OAuth2 applications (without secrets)
Delete an OAuth2 application by its ID
Add tests for create/list/delete

routers/api/v1/user/app.go

ghost · 2020-02-24T15:22:46Z

Added List and Delete methods as requested.

routers/api/v1/user/app.go

models/oauth2_application.go

6543

great work @IGZgustavomarin only smal nits left and we need some tests

routers/api/v1/user/app.go

templates/swagger/v1_json.tmpl

routers/api/v1/swagger/app.go

ghost · 2020-02-24T19:09:14Z

great work @IGZgustavomarin only smal nits left and we need some tests

this is a big project, I've tried to setup my environment for testing but couldn't do it. I'll try again. But any help is welcome.

Also not sure which criteria to follow add tests. Which methods of this PR should be covered?

NOTE: Although, I did manual tests by building/running as a local docker image and sending requests with Postman.

techknowlogick · 2020-02-24T19:10:45Z

CI Fail with:

modules/convert/convert.go:392:1: exported function ToOAuth2Application should have comment or be unexported

ghost · 2020-02-24T19:12:18Z

CI Fail with:

modules/convert/convert.go:392:1: exported function ToOAuth2Application should have comment or be unexported

fixed

routers/api/v1/swagger/app.go

codecov-io · 2020-02-24T19:49:11Z

Codecov Report

Merging #10437 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10437      +/-   ##
==========================================
- Coverage   43.75%   43.75%   -0.01%     
==========================================
  Files         586      586              
  Lines       81633    81633              
==========================================
- Hits        35717    35716       -1     
  Misses      41492    41492              
- Partials     4424     4425       +1

Impacted Files	Coverage Δ
modules/process/manager.go	`74.69% <0%> (-3.62%)`	⬇️
modules/git/command.go	`86.95% <0%> (-2.61%)`	⬇️
modules/log/file.go	`75.52% <0%> (-2.1%)`	⬇️
modules/queue/unique_queue_disk_channel.go	`53.84% <0%> (-1.93%)`	⬇️
services/pull/check.go	`50% <0%> (-1.22%)`	⬇️
services/pull/pull.go	`34.89% <0%> (-0.3%)`	⬇️
models/error.go	`29.23% <0%> (+0.51%)`	⬆️
modules/git/repo.go	`47.7% <0%> (+0.91%)`	⬆️
modules/git/utils.go	`70.14% <0%> (+4.47%)`	⬆️
modules/indexer/stats/db.go	`50% <0%> (+9.37%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e979cb6...3d0c072. Read the comment docs.

ghost · 2020-02-25T13:49:25Z

Kudos to @6543 for all the time you spent helping me to implement a better features and the tests.

lunny · 2020-02-25T15:55:23Z

@IGZgustavomarin CI failed.

ghost · 2020-02-25T16:15:01Z

@IGZgustavomarin CI failed.

Yes, but it fails on different places on each pipeline, and none on TestOAuth2Application features that this PR contains. This are the error messages:

First on testing-amd64 > test-mysql >:

RepoAssignment Invalid repo /go/src/code.gitea.io/gitea/integrations/gitea-integration-mysql/gitea-repositories/user2/repo1.git: no such file or directory
--
314 | release_test.go:65:
315 | Error Trace:	integration_test.go:400
316 | integration_test.go:258
317 | release_test.go:65
318 | Error:      	Not equal:
319 | expected: 200
320 | actual  : 500
321 | Test:       	TestViewReleases
322 | Messages:   	Request: GET /user2/repo1/releases
323 | testlogger.go:73: 2020/02/25 13:02:39 ...ers/routes/routes.go:105:func1() [I] Completed GET /user2/repo1/releases 500 Internal Server Error in 6.060573ms

And then on testing-arm64 > test-sqlite >:

[E] DeleteRepository: database is deadlocked
--
287 | testlogger.go:73: 2020/02/25 12:56:04 ...ers/routes/routes.go:105:func1() [I] Completed DELETE /api/v1/repos/user2/repo-tmp-17?token=fc86029a7982c983a0505fa36c003dce11bcfad8 500 Internal Server Error in 94.444323ms

It doesn't seem related to this feature. Can the tests be run again? Or, in caseyou think this is related with this code, how to start debugging it.

Thanks!

…e type.

… swagger docs.

6543 · 2020-02-25T16:52:07Z

@IGZgustavomarin if it CI fail unrelated the easyest way to restart is to push an empty commit: git commit -m 'CI restart' --allow-empty & git push ...

ghost · 2020-02-25T17:16:42Z

@IGZgustavomarin if it CI fail unrelated the easyest way to restart is to push an empty commit: git commit -m 'CI restart' --allow-empty & git push ...

There were some changes on master branch so I just rebased and pushed again. It seems all green now.

6543 · 2020-02-25T17:41:28Z

the most convenient methot to keep your pull up to date is the "update branch" botton of github
and since a pull is squash-merged it doesnt mather in git history anyway

6543 · 2020-02-25T23:45:28Z

ping lgtm

6543 · 2020-02-27T23:48:39Z

@lunny @adelowo this pull need your review or review-dismiss

guillep2k · 2020-02-29T06:19:08Z

Ping LG-TM

6543 reviewed Feb 24, 2020

View reviewed changes

routers/api/v1/user/app.go Outdated Show resolved Hide resolved

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2020

ghost force-pushed the feat/api-oauth2-applications branch 2 times, most recently from 6e4d549 to b179bfa Compare February 24, 2020 15:37

ghost changed the title ~~add API endpoint to create OAuth2 Application.~~ add API endpoint to manage OAuth2 Application (list/create/delete) Feb 24, 2020

ghost changed the title ~~add API endpoint to manage OAuth2 Application (list/create/delete)~~ adds API endpoints to manage OAuth2 Application (list/create/delete) Feb 24, 2020

ghost requested review from lunny and adelowo February 24, 2020 15:44

techknowlogick approved these changes Feb 24, 2020

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2020

techknowlogick added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 24, 2020

techknowlogick added this to the 1.12.0 milestone Feb 24, 2020

6543 reviewed Feb 24, 2020

View reviewed changes

routers/api/v1/user/app.go Show resolved Hide resolved

6543 reviewed Feb 24, 2020

View reviewed changes

models/oauth2_application.go Outdated Show resolved Hide resolved

6543 reviewed Feb 24, 2020

View reviewed changes

routers/api/v1/user/app.go Outdated Show resolved Hide resolved

6543 reviewed Feb 24, 2020

View reviewed changes

templates/swagger/v1_json.tmpl Show resolved Hide resolved

6543 reviewed Feb 24, 2020

View reviewed changes

routers/api/v1/swagger/app.go Show resolved Hide resolved

ghost force-pushed the feat/api-oauth2-applications branch from 9521b76 to 7d2b16e Compare February 24, 2020 19:00

ghost force-pushed the feat/api-oauth2-applications branch from 7d2b16e to 2f7d6c8 Compare February 24, 2020 19:10

6543 reviewed Feb 24, 2020

View reviewed changes

routers/api/v1/swagger/app.go Outdated Show resolved Hide resolved

6543 reviewed Feb 24, 2020

View reviewed changes

routers/api/v1/swagger/app.go Outdated Show resolved Hide resolved

ghost force-pushed the feat/api-oauth2-applications branch 2 times, most recently from aa6c31c to f4120f4 Compare February 24, 2020 19:45

Gustavo Marin added 10 commits February 25, 2020 17:15

add API endpoint to create OAuth2 Application.

f1f2a57

move endpoint to /user. Add swagger documentations and proper respons…

a7d0c5c

…e type.

change json tags to snake_case. add CreateOAuth2ApplicationOptions to…

a5ad56d

… swagger docs.

change response status to Created (201)

f6c94fe

add methods to list OAuth2 apps and delete an existing OAuth2 app by ID.

23c45c0

add APIFormat convert method and file header

0355496

fixed header

f1b5342

hide secret on oauth2 application list

2c76176

add Created time to API response

c42988d

add API integration tests for create/list/delete OAuth2 applications.

c296222

ghost force-pushed the feat/api-oauth2-applications branch from 07d51c3 to c296222 Compare February 25, 2020 16:16

Merge branch 'master' into feat/api-oauth2-applications

c8b0c3c

zeripath and others added 4 commits February 28, 2020 14:34

Merge branch 'master' into feat/api-oauth2-applications

e979cb6

Merge branch 'master' into feat/api-oauth2-applications

3d0c072

Merge branch 'master' into feat/api-oauth2-applications

c54d3f6

Merge branch 'master' into feat/api-oauth2-applications

8fdd4cb

guillep2k merged commit af61b22 into go-gitea:master Feb 29, 2020

guillep2k approved these changes Feb 29, 2020

View reviewed changes

zeripath mentioned this pull request May 17, 2020

Changelog for v1.12.0-rc1 #11462

Merged

zeripath changed the title ~~adds API endpoints to manage OAuth2 Application (list/create/delete)~~ Add API endpoints to manage OAuth2 Application (list/create/delete) May 17, 2020

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add API endpoints to manage OAuth2 Application (list/create/delete) #10437

Add API endpoints to manage OAuth2 Application (list/create/delete) #10437

ghost commented Feb 24, 2020 •

edited by ghost

ghost commented Feb 24, 2020

6543 left a comment

ghost commented Feb 24, 2020 •

edited by ghost

techknowlogick commented Feb 24, 2020

ghost commented Feb 24, 2020

codecov-io commented Feb 24, 2020 •

edited

ghost commented Feb 25, 2020

lunny commented Feb 25, 2020

ghost commented Feb 25, 2020

6543 commented Feb 25, 2020

ghost commented Feb 25, 2020

6543 commented Feb 25, 2020

6543 commented Feb 25, 2020

6543 commented Feb 27, 2020

guillep2k commented Feb 29, 2020

Add API endpoints to manage OAuth2 Application (list/create/delete) #10437

Add API endpoints to manage OAuth2 Application (list/create/delete) #10437

Conversation

ghost commented Feb 24, 2020 • edited by ghost

ghost commented Feb 24, 2020

6543 left a comment

Choose a reason for hiding this comment

ghost commented Feb 24, 2020 • edited by ghost

techknowlogick commented Feb 24, 2020

ghost commented Feb 24, 2020

codecov-io commented Feb 24, 2020 • edited

Codecov Report

ghost commented Feb 25, 2020

lunny commented Feb 25, 2020

ghost commented Feb 25, 2020

6543 commented Feb 25, 2020

ghost commented Feb 25, 2020

6543 commented Feb 25, 2020

6543 commented Feb 25, 2020

6543 commented Feb 27, 2020

guillep2k commented Feb 29, 2020

ghost commented Feb 24, 2020 •

edited by ghost

ghost commented Feb 24, 2020 •

edited by ghost

codecov-io commented Feb 24, 2020 •

edited