Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various dark theme fixes #10416

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Various dark theme fixes #10416

merged 2 commits into from
Feb 23, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Feb 22, 2020

  • beautify simplemde, remove header hover effect (does not play well with border colors), remove double border separators
  • fix colored outline buttons
  • fix disabled style
  • fix positive messages
  • fix markdown header border and quote block
  • adjust footer color
  • adjust file icons and release list timeline

Some screenshots:

image

image

image

image

image

- beatify simplemde, remove header hover effect (does not play well with
  border colors), remove double border separators
- fix colored outline buttons
- fix disabled style
- fix positive messages
- fix markdown header border and quote block
- adjust footer color
- adjust file icons and release list timeline
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 22, 2020
@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #10416 into master will decrease coverage by 0.08%.
The diff coverage is 2.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10416      +/-   ##
==========================================
- Coverage   43.74%   43.65%   -0.09%     
==========================================
  Files         586      586              
  Lines       81265    81351      +86     
==========================================
- Hits        35547    35517      -30     
- Misses      41318    41441     +123     
+ Partials     4400     4393       -7
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 34.82% <0%> (-0.36%) ⬇️
routers/repo/editor.go 26.09% <0%> (-0.66%) ⬇️
routers/utils/utils.go 72% <0%> (-28%) ⬇️
services/pull/merge.go 49.45% <0%> (-0.99%) ⬇️
models/error.go 29.49% <0%> (-1.46%) ⬇️
routers/repo/pull.go 28.61% <0%> (-0.09%) ⬇️
modules/repofiles/temp_repo.go 58.54% <13.63%> (-3.57%) ⬇️
services/pull/check.go 35.36% <0%> (-14.64%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0%> (-1.93%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8284c8a...7bf0df5. Read the comment docs.

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Feb 22, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 22, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2020
@jolheiser jolheiser merged commit 0bba3f9 into go-gitea:master Feb 23, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants