Reading pull attachments should depend on read UnitTypePullRequests #10346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolheiser
approved these changes
Feb 18, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Feb 18, 2020
GiteaBot
added
lgtm/done
drahkrub
reviewed
Feb 18, 2020
| @@ -79,7 +79,11 @@ func (a *Attachment) LinkedRepository() (*Repository, UnitType, error) { | |||
| return nil, UnitTypeIssues, err | |||
There was a problem hiding this comment.
Maybe the correct unitType (UnitTypePullRequests instead of UnitTypeIssues) is of interest here, too?!
There was a problem hiding this comment.
don't have an issue to be able to check if it is a pull
There was a problem hiding this comment.
and in any case if err is not nil then the unitType is not used:
repository, unitType, err := attach.LinkedRepository()
if err != nil {
ctx.ServerError("LinkedRepository", err)
return
}…github.com:zeripath/gitea into fix-10336-attachments-on-pulls-depend-on-read-pull
Codecov Report
@@ Coverage Diff @@
## master #10346 +/- ##
==========================================
+ Coverage 43.69% 43.72% +0.02%
==========================================
Files 585 585
Lines 81023 81023
==========================================
+ Hits 35407 35424 +17
+ Misses 41227 41212 -15
+ Partials 4389 4387 -2
Continue to review full report at Codecov.
|
guillep2k
pushed a commit
to guillep2k/gitea
that referenced
this pull request
Feb 19, 2020
…o-gitea#10346) * Make pull attachments depend on read UnitTypePullRequests Fixes go-gitea#10336 * Fix test
jolheiser
pushed a commit
that referenced
this pull request
Feb 19, 2020
…10346) (#10354) Co-authored-by: zeripath <[email protected]>
zeripath
deleted the
fix-10336-attachments-on-pulls-depend-on-read-pull
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these would depend on read UnitTypeIssues.
Fixes #10336