Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration information update bug when linked github account #10310

Merged
merged 4 commits into from
Feb 18, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 17, 2020

As title.

@lunny lunny added this to the 1.12.0 milestone Feb 17, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #10310 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10310      +/-   ##
==========================================
- Coverage   43.72%   43.71%   -0.02%     
==========================================
  Files         585      585              
  Lines       81016    81016              
==========================================
- Hits        35423    35413      -10     
- Misses      41208    41215       +7     
- Partials     4385     4388       +3
Impacted Files Coverage Δ
services/pull/commit_status.go 5.19% <0%> (ø) ⬆️
modules/templates/helper.go 40.73% <100%> (ø) ⬆️
services/pull/check.go 32.92% <0%> (-5.49%) ⬇️
modules/git/command.go 86.95% <0%> (-2.61%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
services/pull/pull.go 32.43% <0%> (-1.51%) ⬇️
modules/indexer/stats/db.go 50% <0%> (ø) ⬆️
modules/git/repo.go 47.7% <0%> (+0.91%) ⬆️
modules/queue/workerpool.go 60.14% <0%> (+2.13%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db4329...23c8fb7. Read the comment docs.

@techknowlogick techknowlogick merged commit ce0413f into go-gitea:master Feb 18, 2020
@techknowlogick
Copy link
Member

Please send backport :)

@lunny lunny deleted the lunny/fix_upgrade_reaction branch February 18, 2020 01:02
@lunny
Copy link
Member Author

lunny commented Feb 18, 2020

@techknowlogick Just found migrating reviews and reactions are supported on v1.12. So I removed backport/v1.11 label.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants