Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: improve mobile review-box sizing #10297

Merged
merged 2 commits into from
Feb 16, 2020
Merged

Conversation

sapk
Copy link
Member

@sapk sapk commented Feb 16, 2020

On mobile, review is not possible because the button are on the left out of the screen.
This PR is using viewport unit for sizing the review-box.
(which is supported on most browser now https://caniuse.com/#feat=viewport-units)
This also add a scrollbar if needed to the editor bar.

After

On small screen the review box is kept inside the viewport:

On full screen nothing change:

Before

On small screen the review box is was outside the viewport:

On full screen nothing change:

@sapk sapk added the topic/ui Change the appearance of the Gitea UI label Feb 16, 2020
@sapk sapk added this to the 1.12.0 milestone Feb 16, 2020
@guillep2k
Copy link
Member

Could you please add a height maximum as well? Since I use a larger DPI setting on my notebook (not mobile), the review buttons always get placed outside the screen (I can scroll down, however):

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 16, 2020
@sapk
Copy link
Member Author

sapk commented Feb 16, 2020

@guillep2k can we keep that for an other PR ?
I have seen the same problem during testing but it easy to scrolldown to access the button.

@guillep2k
Copy link
Member

@guillep2k can we keep that for an other PR ?
I have seen the same problem during testing but it easy to scrolldown to access the button.

OK, I can't do it myself because I don't have enough experience with CSS and its endless list of caveats. 😄

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 16, 2020
@sapk
Copy link
Member Author

sapk commented Feb 16, 2020

@guillep2k I am not an expert also so I try to limit to the strict minimum even on the css selector to not impact other element

@codecov-io
Copy link

Codecov Report

Merging #10297 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10297      +/-   ##
==========================================
- Coverage   43.73%   43.71%   -0.02%     
==========================================
  Files         585      585              
  Lines       81017    81017              
==========================================
- Hits        35434    35419      -15     
- Misses      41201    41212      +11     
- Partials     4382     4386       +4
Impacted Files Coverage Δ
modules/indexer/stats/queue.go 62.5% <0%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0%> (-18.75%) ⬇️
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 63.52% <0%> (-2.52%) ⬇️
modules/git/repo.go 46.78% <0%> (-2.3%) ⬇️
models/user.go 49.54% <0%> (ø) ⬆️
models/notification.go 64.13% <0%> (+0.84%) ⬆️
services/pull/pull.go 33.93% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d290d...677870e. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 16, 2020
@lafriks lafriks merged commit cdda5c4 into go-gitea:master Feb 16, 2020
@sapk sapk deleted the ui-mob-review branch February 16, 2020 21:04
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants