-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: improve mobile review-box sizing #10297
Conversation
@guillep2k can we keep that for an other PR ? |
OK, I can't do it myself because I don't have enough experience with CSS and its endless list of caveats. 😄 |
@guillep2k I am not an expert also so I try to limit to the strict minimum even on the css selector to not impact other element |
Codecov Report
@@ Coverage Diff @@
## master #10297 +/- ##
==========================================
- Coverage 43.73% 43.71% -0.02%
==========================================
Files 585 585
Lines 81017 81017
==========================================
- Hits 35434 35419 -15
- Misses 41201 41212 +11
- Partials 4382 4386 +4
Continue to review full report at Codecov.
|
On mobile, review is not possible because the button are on the left out of the screen.
This PR is using viewport unit for sizing the review-box.
(which is supported on most browser now https://caniuse.com/#feat=viewport-units)
This also add a scrollbar if needed to the editor bar.
After
On small screen the review box is kept inside the viewport:
On full screen nothing change:
Before
On small screen the review box is was outside the viewport:
On full screen nothing change: