ui: improve mobile review-box sizing #10297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile, review is not possible because the button are on the left out of the screen.
This PR is using viewport unit for sizing the review-box.
(which is supported on most browser now https://caniuse.com/#feat=viewport-units)
This also add a scrollbar if needed to the editor bar.
After
On small screen the review box is kept inside the viewport:
On full screen nothing change:
Before
On small screen the review box is was outside the viewport:
On full screen nothing change: