Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification: queue ui.go notification-service #10281

Merged

Conversation

zeripath
Copy link
Contributor

As requested by @lunny in #9902 this extracts the single commit that moves the ui.go notification-service into a separate queue.

@zeripath zeripath added the type/enhancement An improvement of existing functionality label Feb 15, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 15, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 15, 2020
@lunny
Copy link
Member

lunny commented Feb 15, 2020

A small nit, otherwise LGTM.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 15, 2020
@codecov-io
Copy link

Codecov Report

Merging #10281 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10281      +/-   ##
==========================================
+ Coverage   43.67%   43.72%   +0.04%     
==========================================
  Files         585      585              
  Lines       81017    81017              
==========================================
+ Hits        35387    35421      +34     
+ Misses      41250    41215      -35     
- Partials     4380     4381       +1
Impacted Files Coverage Δ
modules/queue/workerpool.go 58% <100%> (+11.38%) ⬆️
models/notification.go 63.29% <0%> (-1.9%) ⬇️
routers/repo/view.go 39.06% <0%> (-0.85%) ⬇️
models/error.go 30.4% <0%> (-0.55%) ⬇️
services/pull/patch.go 62.26% <0%> (+1.88%) ⬆️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
modules/git/command.go 89.56% <0%> (+2.6%) ⬆️
services/pull/check.go 36.58% <0%> (+3.65%) ⬆️
modules/indexer/stats/db.go 59.37% <0%> (+9.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1645d24...d8eb63b. Read the comment docs.

@techknowlogick techknowlogick merged commit 791b109 into go-gitea:master Feb 16, 2020
@zeripath zeripath deleted the separate-out-ui-notifier-queue branch February 16, 2020 09:36
@lunny lunny mentioned this pull request Feb 18, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants