-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG Octicon fixes #10237
SVG Octicon fixes #10237
Conversation
Signed-off-by: jolheiser <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10237 +/- ##
==========================================
+ Coverage 43.66% 43.67% +<.01%
==========================================
Files 582 582
Lines 80047 80047
==========================================
+ Hits 34955 34962 +7
+ Misses 40756 40748 -8
- Partials 4336 4337 +1
Continue to review full report at Codecov.
|
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
@silverwind Added suggestions. |
Can you put Here: gitea/templates/base/head.tmpl Line 88 in 6c823c7
|
Signed-off-by: jolheiser <[email protected]>
@silverwind Done, and good idea. 👍 EDIT: Didn't see the last edit, so right now it's not de-structured. Is that okay or should I change it? |
Yes I'd prefer it destructured for conciseness. Can you also refactor to the original go variable names? Like const { AppSubUrl, StaticUrlPrefix } = window.config; |
Signed-off-by: jolheiser <[email protected]>
|
A handful of fixes for Octicons. Noticed after clicking around try a little.
Moved the JS
svg
function to another file so it can be imported by other files as needed.Also moved variables
suburl
andstaticPrefix
to the globalwindow.config
object so they don't need to be passed around.