SVG Octicon fixes

[jolheiser]

A handful of fixes for Octicons. Noticed after clicking around try a little.

Moved the JS svg function to another file so it can be imported by other files as needed.

Also moved variables suburl and staticPrefix to the global window.config object so they don't need to be passed around.

[codecov-io]

Codecov Report

Merging #10237 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10237      +/-   ##
==========================================
+ Coverage   43.66%   43.67%   +<.01%     
==========================================
  Files         582      582              
  Lines       80047    80047              
==========================================
+ Hits        34955    34962       +7     
+ Misses      40756    40748       -8     
- Partials     4336     4337       +1

Impacted Files	Coverage Δ
modules/indexer/stats/db.go	55.17% <0%> (-10.35%)	⬇️
services/pull/pull.go	32.43% <0%> (-1.51%)	⬇️
modules/log/event.go	64.61% <0%> (-1.03%)	⬇️
models/error.go	30.95% <0%> (+0.54%)	⬆️
services/pull/patch.go	62.89% <0%> (+2.51%)	⬆️
services/pull/temp_repo.go	31.62% <0%> (+2.56%)	⬆️
services/pull/check.go	35.36% <0%> (+4.26%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79fb8f5...60c6956. Read the comment docs.

[jolheiser]

@silverwind Added suggestions.

[silverwind]

Can you put suburl and staticPrefix on the window.config object in the page header template? I think it's easier that way and we don't need to pass it everywhere as arguments. You can then destructure it at the start of files like const {suburl, staticPrefix} = window.config (after the imports).

Here:

gitea/templates/base/head.tmpl

Line 88 in 6c823c7

window.config = {

[jolheiser]

@silverwind Done, and good idea. 👍

EDIT: Didn't see the last edit, so right now it's not de-structured. Is that okay or should I change it?

[silverwind]

Yes I'd prefer it destructured for conciseness. Can you also refactor to the original go variable names? Like

const { AppSubUrl, StaticUrlPrefix } = window.config;

[jolheiser]

It seems the de-structure hasn't worked, as it is now undefined when I test locally.
After doing a hard reload it picked it up, ignore me.