Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 404 error message #10214

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Improve 404 error message #10214

merged 1 commit into from
Feb 10, 2020

Conversation

guillep2k
Copy link
Member

Since 404 does not exactly mean "page not found" as it should, I thought it would be nice to add some clarification about the error message for better usability.

image

@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Feb 10, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Feb 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #10214 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10214      +/-   ##
==========================================
- Coverage   43.64%   43.63%   -0.02%     
==========================================
  Files         576      576              
  Lines       79716    79716              
==========================================
- Hits        34791    34783       -8     
- Misses      40627    40635       +8     
  Partials     4298     4298
Impacted Files Coverage Δ
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
services/pull/check.go 32.92% <0%> (-2.44%) ⬇️
modules/queue/unique_queue_disk_channel.go 54.48% <0%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5418a6...bd5784a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 10, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2020
@lafriks lafriks merged commit 069a96e into go-gitea:master Feb 10, 2020
@guillep2k guillep2k deleted the fix-404 branch February 10, 2020 21:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants