Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move clipboard.js to npm/webpack #10183

Merged
merged 2 commits into from
Feb 7, 2020
Merged

move clipboard.js to npm/webpack #10183

merged 2 commits into from
Feb 7, 2020

Conversation

silverwind
Copy link
Member

  • created lazy-loaded webpack chunk for clipboard.js
  • upgraded clipboard.js from 1.5.9 to 2.0.4
  • parallelize initialization of all lazy-loaded features

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 7, 2020
@silverwind
move clipboard.js to npm/webpack
24bd5a9 
- created lazy-loaded webpack chunk for clipboard.js
- upgraded clipboard.js from 1.5.9 to 2.0.4
- parallelize initialization of all lazy-loaded features
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 7, 2020
@sapk sapk added the topic/ui Change the appearance of the Gitea UI label Feb 7, 2020
@sapk sapk added this to the 1.12.0 milestone Feb 7, 2020
@sapk sapk added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #10183 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10183      +/-   ##
==========================================
- Coverage   43.41%   43.41%   -0.01%     
==========================================
  Files         576      576              
  Lines       79642    79642              
==========================================
- Hits        34580    34579       -1     
  Misses      40786    40786              
- Partials     4276     4277       +1
Impacted Files Coverage Δ
modules/queue/unique_queue_disk_channel.go 52.56% <0%> (-1.93%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bd5a9...9813194. Read the comment docs.

@sapk sapk merged commit 4721d45 into go-gitea:master Feb 7, 2020
@silverwind silverwind deleted the clipboardjs branch February 7, 2020 23:04
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @codecov-io @sapk @6543 @GiteaBot