Fix topics dropdown

[jolheiser]

Fixes #10160

Related to fomantic switch, so needs a backport as well.

Note that {variable} is semantic syntax, not JS ${variable}

[silverwind]

Seems correct according to https://semantic-ui.com/modules/dropdown.html#match-search-query-on-server

[zeripath]

Presumably fomantic is doing the encodeUriComponent itself?

[codecov-io]

Codecov Report

Merging #10167 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10167      +/-   ##
==========================================
+ Coverage    43.4%   43.41%   +0.01%     
==========================================
  Files         576      576              
  Lines       79640    79640              
==========================================
+ Hits        34566    34575       +9     
+ Misses      40798    40789       -9     
  Partials     4276     4276

Impacted Files	Coverage Δ
modules/process/manager.go	74.69% <0%> (-3.62%)	⬇️
modules/queue/workerpool.go	45.55% <0%> (-1.07%)	⬇️
models/error.go	30.95% <0%> (+0.54%)	⬆️
routers/repo/view.go	40% <0%> (+0.86%)	⬆️
services/pull/check.go	33.33% <0%> (+1.85%)	⬆️
modules/queue/unique_queue_disk_channel.go	54.48% <0%> (+1.92%)	⬆️
models/unit.go	39.5% <0%> (+2.46%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5262f3c...21898f8. Read the comment docs.

[silverwind]

Presumably fomantic is doing the encodeUriComponent itself?

I think fetch/XHR do that automatically in any case.

[alexanderadam]

Awesome, thank you for this fast fix! 🙏