Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow emoji on popup label #10166

Merged
merged 5 commits into from
Feb 8, 2020
Merged

Allow emoji on popup label #10166

merged 5 commits into from
Feb 8, 2020

Conversation

jaqra
Copy link
Contributor

@jaqra jaqra commented Feb 6, 2020

No description provided.

@silverwind
Copy link
Member

Does it actually work? I thought you need to call emojify.run(element) on dynamically inserted DOM nodes.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 6, 2020
@jaqra jaqra changed the title Allow emoji on popup label [WIP] Allow emoji on popup label Feb 6, 2020
@codecov-io
Copy link

Codecov Report

Merging #10166 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10166   +/-   ##
=======================================
  Coverage   43.41%   43.41%           
=======================================
  Files         576      576           
  Lines       79640    79640           
=======================================
  Hits        34577    34577           
  Misses      40786    40786           
  Partials     4277     4277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c9160...63f2ccf. Read the comment docs.

@jaqra jaqra changed the title [WIP] Allow emoji on popup label Allow emoji on popup label Feb 7, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2020
@sapk sapk added the topic/ui Change the appearance of the Gitea UI label Feb 8, 2020
@sapk sapk added this to the 1.12.0 milestone Feb 8, 2020
@sapk sapk merged commit 7d8a2d0 into go-gitea:master Feb 8, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jaqra @silverwind @codecov-io @guillep2k @sapk @GiteaBot @metiftikci