Show download count info in release list

[lafriks]

Fixes #9265

[codecov-io]

Codecov Report

Merging #10124 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10124      +/-   ##
==========================================
+ Coverage   43.38%    43.4%   +0.01%     
==========================================
  Files         576      576              
  Lines       79623    79623              
==========================================
+ Hits        34548    34560      +12     
+ Misses      40794    40785       -9     
+ Partials     4281     4278       -3

Impacted Files	Coverage Δ
routers/org/setting.go	0% <ø> (ø)	⬆️
routers/api/v1/admin/user.go	30.19% <0%> (ø)	⬆️
models/gpg_key.go	55.37% <0%> (+0.55%)	⬆️
modules/queue/unique_queue_disk_channel.go	54.48% <0%> (+1.92%)	⬆️
modules/queue/workerpool.go	46.61% <0%> (+2.13%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265497d...56dfd32. Read the comment docs.

[jolheiser]

How does this compare to https://github.com/dustin/go-humanize/blob/master/comma.go#L11-L44?

It doesn't need to handle negative numbers in the context of this PR (https://play.golang.org/p/5wF98ePRPc-) but perhaps it would be nice to have so we can re-use this function in other areas?

[lafriks]

I did not want to add new library just for this but it could probably be useful also in other places

[jolheiser]

Yes, agreed we don't need that whole library. Maybe just extending it to negatives, if possible?

iirc there is an issue for humanizing diff counts, which is the only thing I can think of with negatives but I'm sure there are more.

[lafriks]

Actually it is second function already so I just added go-humanize (FileSize was actually copied over already)

[jolheiser]

A nit and question, otherwise LGTM

[6543]

nice - you only have to edit the tests