Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch page pull request title and link error #10092

Merged
merged 2 commits into from
Feb 1, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 1, 2020

Fix #8305.

This PR will display <owner>/<repo>#<number> on branches if the repository is a forked repository and the branch has sent a PR to base repository.

@lunny lunny added the type/bug label Feb 1, 2020
@lunny lunny added this to the 1.12.0 milestone Feb 1, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 1, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 1, 2020
@lafriks
Copy link
Member

lafriks commented Feb 1, 2020

Integration tests fail

@codecov-io
Copy link

Codecov Report

Merging #10092 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10092      +/-   ##
==========================================
+ Coverage   43.45%   43.45%   +<.01%     
==========================================
  Files         566      566              
  Lines       78987    78989       +2     
==========================================
+ Hits        34321    34324       +3     
+ Misses      40430    40426       -4     
- Partials     4236     4239       +3
Impacted Files Coverage Δ
routers/repo/branch.go 55.72% <100%> (+0.34%) ⬆️
services/pull/patch.go 67.92% <0%> (-1.89%) ⬇️
modules/queue/manager.go 60.51% <0%> (-1.54%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
routers/repo/view.go 39.47% <0%> (+0.87%) ⬆️
models/unit.go 39.5% <0%> (+2.46%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 107a694...da09245. Read the comment docs.

@lafriks lafriks merged commit 3ccd271 into go-gitea:master Feb 1, 2020
@lafriks
Copy link
Member

lafriks commented Feb 1, 2020

Please send backports

@lunny lunny deleted the lunny/fix_branch_pr branch February 1, 2020 14:15
lunny added a commit to lunny/gitea that referenced this pull request Feb 1, 2020
* Fix branch page pull request title and link error

* Fix ui
lunny added a commit to lunny/gitea that referenced this pull request Feb 1, 2020
* Fix branch page pull request title and link error

* Fix ui
zeripath pushed a commit that referenced this pull request Feb 1, 2020
* Fix branch page pull request title and link error (#10092)
zeripath pushed a commit that referenced this pull request Feb 1, 2020
* Fix branch page pull request title and link error (#10092)
* Fix tmpl
lafriks added a commit that referenced this pull request Feb 14, 2020
* Fix branch page pull request title and link error (#10092)

* Fix branch page pull request title and link error

* Fix ui

* Fix reply on code review (#10227)

Co-authored-by: zeripath <[email protected]>

* Revert unrelated change

* Fix lint

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 15, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Branch View] Wrong link for cross PR
5 participants