Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove migration support from versions earlier than 1.6.0 #10026

Merged
merged 10 commits into from
Jan 31, 2020
Merged

Remove migration support from versions earlier than 1.6.0 #10026

merged 10 commits into from
Jan 31, 2020

Conversation

guillep2k
Copy link
Member

Closes #9953

This PR removes support for migrations earlier than 1.6.0, as per vote at #9953.

The motivation is that users migrating from versions earlier than that are getting errors due to missing tables and columns. Our usual recommendation (upgrade in steps through intermediate versions) normally works for them.

@jolheiser
Copy link
Member

jolheiser commented Jan 27, 2020 •
edited

Now that I see this I am having second thoughts. 😅
If we remove them outright, then users in version lower than 1.6.0 will need to apply the migrations manually without actually knowing what to migrate.

Can we provide the removed migrations in another tool perhaps? It could instead run Sync2 in between migrations (since I believe that ends up being the root cause of the problem).

Ugh, brain misfire, of course they can run an older version of Gitea. 🤦‍♂

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 27, 2020
@codecov-io
Copy link

codecov-io commented Jan 27, 2020 •
edited

Codecov Report

Merging #10026 into master will decrease coverage by 0.02%.
The diff coverage is 9.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10026      +/-   ##
==========================================
- Coverage   43.38%   43.36%   -0.03%     
==========================================
  Files         564      565       +1     
  Lines       78867    78896      +29     
==========================================
- Hits        34220    34214       -6     
- Misses      40438    40473      +35     
  Partials     4209     4209
Impacted Files Coverage Δ
models/migrations/migrations.go 4.16% <ø> (ø) ⬆️
models/repo.go 49.66% <0%> (ø) ⬆️
models/migrations/v126.go 0% <0%> (ø)
models/topic.go 62.24% <18.75%> (-4.43%) ⬇️
services/pull/temp_repo.go 31.62% <0%> (-5.99%) ⬇️
modules/queue/workerpool.go 46.61% <0%> (-1.78%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
modules/queue/manager.go 62.05% <0%> (+1.53%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11de45e...5ffbee5. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2020
@6543
Copy link
Member

6543 commented Jan 28, 2020

tested if version nr changes -> stay the same so gite it a go :)

lafriks
lafriks requested changes Jan 29, 2020
View reviewed changes
models/migrations/migrations.go Outdated Show resolved Hide resolved
@lafriks lafriks added pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/miscellaneous labels Jan 29, 2020
@lafriks lafriks added this to the 1.12.0 milestone Jan 29, 2020
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Jan 29, 2020
6543
6543 requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs ...

@6543
Copy link
Member

6543 commented Jan 29, 2020

@guillep2k I think we should leave a hint on https://docs.gitea.io/en-us/upgrade-from-gogs/#upgrading-to-most-recent-gitea-version and if there are other places witch tell about upgrading update them too

@guillep2k
Copy link
Member Author

@6543 done.

6543
6543 approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2020
bagasme
bagasme reviewed Jan 30, 2020
View reviewed changes
Copy link
Contributor

@bagasme bagasme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what about checking version?

@6543
Copy link
Member

6543 commented Jan 30, 2020

@bagasme what do you mean, migration already checkes DB version

@bagasme
Copy link
Contributor

bagasme commented Jan 30, 2020

@6543 checking Gitea version

@6543
Copy link
Member

6543 commented Jan 30, 2020

Not needed

jolheiser
jolheiser approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doc nit, otherwise LGTM

docs/content/doc/upgrade/from-gogs.en-us.md Outdated Show resolved Hide resolved
@6543
Copy link
Member

6543 commented Jan 31, 2020

ping lgtm

@lafriks
Copy link
Member

lafriks commented Jan 31, 2020

ping it again ;)

@6543
Copy link
Member

6543 commented Jan 31, 2020

Who does the merging ?

@lunny lunny merged commit d816f70 into go-gitea:master Jan 31, 2020
@jolheiser jolheiser mentioned this pull request Feb 14, 2020
Closed
7 tasks
@guillep2k guillep2k deleted the deprecate-old branch February 17, 2020 04:53
This was referenced Jun 8, 2020
Closed
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagasme bagasme bagasme left review comments

@lafriks lafriks lafriks approved these changes

@sapk sapk sapk approved these changes

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/miscellaneous
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Deprecate very old migrations
10 participants
@guillep2k @jolheiser @codecov-io @6543 @bagasme @lafriks @sapk @lunny @GiteaBot @delvh