Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On merge of already closed PR redirect back to the pulls page #10010

Merged
merged 6 commits into from
Jan 27, 2020

Conversation

zeripath
Copy link
Contributor

No description provided.

@zeripath zeripath added this to the 1.12.0 milestone Jan 26, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 26, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2020
@zeripath
Copy link
Contributor Author

zeripath commented Jan 26, 2020

It seemed simplest to just redirect back with the message "The pull request has been closed."

We could be cleverer with double checking that it is a pull etc. but I dunno if it is worth it.


I've added a few more checks.

@codecov-io
Copy link

codecov-io commented Jan 26, 2020

Codecov Report

Merging #10010 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10010      +/-   ##
==========================================
- Coverage   42.25%   42.25%   -0.01%     
==========================================
  Files         610      610              
  Lines       80373    80384      +11     
==========================================
+ Hits        33963    33964       +1     
- Misses      42230    42241      +11     
+ Partials     4180     4179       -1
Impacted Files Coverage Δ
routers/repo/pull.go 28.7% <0%> (-0.34%) ⬇️
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/patch.go 67.92% <0%> (+1.88%) ⬆️
services/pull/check.go 56.64% <0%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aaafdc...3a1b7ff. Read the comment docs.

routers/repo/pull.go Outdated Show resolved Hide resolved
routers/repo/pull.go Outdated Show resolved Hide resolved
routers/repo/pull.go Outdated Show resolved Hide resolved
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ... but you switched something :D

it appears I am too full of cold to code

Co-Authored-By: 6543 <[email protected]>
@zeripath
Copy link
Contributor Author

It appears that I am too full of cold to code!

@zeripath zeripath merged commit 51f6a7a into go-gitea:master Jan 27, 2020
@zeripath zeripath deleted the on-already-merged-redirect-back branch January 27, 2020 10:26
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants