Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs: Move to use a temporary repo for pushing new prs #10009

Conversation

zeripath
Copy link
Contributor

Whilst testing on my local machine I was able to consistently make a failure with making a PR from one particular repository to the same repository. I'm not certain why this is the case, but changing the pull structure to do the push from a temporary repository fixes this.

@zeripath zeripath added this to the 1.12.0 milestone Jan 26, 2020
@zeripath zeripath changed the title Move to use a temporary repo for pushing new prs PRs: Move to use a temporary repo for pushing new prs Jan 26, 2020
@codecov-io
Copy link

codecov-io commented Jan 26, 2020

Codecov Report

Merging #10009 into master will increase coverage by <.01%.
The diff coverage is 54.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10009      +/-   ##
==========================================
+ Coverage   42.26%   42.26%   +<.01%     
==========================================
  Files         610      611       +1     
  Lines       80403    80404       +1     
==========================================
+ Hits        33980    33983       +3     
- Misses      42239    42244       +5     
+ Partials     4184     4177       -7
Impacted Files Coverage Δ
modules/options/options.go 96.15% <ø> (ø) ⬆️
modules/public/public.go 74.41% <ø> (ø) ⬆️
routers/repo/commit.go 29.66% <0%> (ø) ⬆️
modules/migrations/gitea.go 6.14% <0%> (-0.02%) ⬇️
models/repo_sign.go 36.2% <0%> (ø) ⬆️
models/pull_sign.go 34.86% <0%> (ø) ⬆️
routers/repo/pull.go 28.7% <0%> (ø) ⬆️
services/pull/review.go 0% <0%> (ø) ⬆️
services/gitdiff/gitdiff.go 67.62% <100%> (+1.36%) ⬆️
models/pull.go 43.24% <100%> (+0.33%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03b47c...6793fe8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 26, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2020
services/pull/pull.go Outdated Show resolved Hide resolved
@zeripath zeripath merged commit 797e6f8 into go-gitea:master Jan 28, 2020
@zeripath zeripath deleted the prevent-intermittent-pr-creation-push-failure branch January 28, 2020 10:24
zeripath added a commit to zeripath/gitea that referenced this pull request Jan 28, 2020
* Move to use a temporary repo for pushing new prs
zeripath added a commit that referenced this pull request Jan 28, 2020
* Move to use a temporary repo for pushing new prs
@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 15, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants