Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set private status about Organization (not logged) #714

Closed
4 tasks
camlafit opened this issue Jan 21, 2017 · 22 comments
Closed
4 tasks

Set private status about Organization (not logged) #714

camlafit opened this issue Jan 21, 2017 · 22 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@camlafit
Copy link
Contributor

camlafit commented Jan 21, 2017

  • Gitea version (or commit ref): 1.0.1
  • Git version:
  • Operating system: Linux 386 Jessie
  • Database (use [x]):
    • PostgreSQL
    • [ x ] MySQL / MariadDB
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • [ x ] Not relevant
  • Log gist:

Description

We can set repositories by default to private, then it's useful on internal git hosting , but explore user and organization public page provide all accounts and all organization ( https://try.gitea.io/explore/users & https://try.gitea.io/explore/organizations )

If we want an all private git hosting, we could set private these page and allow display data only to connected account

...

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/41190006-set-private-status-about-organization-and-user-not-logged?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).
@camlafit
Copy link
Contributor Author

Result looks be similar, disable explore page can be an alternative ui configuration. An option to allow :

  • full view public (as actual)
  • full only connected
  • filter to related organization/users to account connected

@lunny lunny added this to the 1.x.x milestone Jan 22, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 22, 2017
@DblK
Copy link
Member

DblK commented May 18, 2017

Do we agree that the option should be on the settings page of the organization?
So if I understand well, we should add a "Visibility" option with a dropdown with 3 choices and take those information in consideration to display (or not) the organization on various page.
Am I right?

@camlafit
Copy link
Contributor Author

Hi

Yes, looks correct on each Organization we could have an option to allow visibility or not about Organization itself and user set in this Organization (public, to each user connected, only to user on same organization, never).

Looks enough as this. If an user can see an organization, he can see also all users related. Doesn't look required to have an option at user level.

@DblK
Copy link
Member

DblK commented May 18, 2017

Okay, I get the idea. What is the use of the fourth choice "Never"? How you will use it?

What about the repositories linked to an organization?
For public repositories:

  • Visible if Organization is Public or ConnectedUser
  • Invisible if Organization is Private

For private repositories:

  • Visible if member are part of the organization AND has a role on this repository.
  • Invisible th rest

@camlafit
Copy link
Contributor Author

Hi

I've thought a "never" option if we need set private on any case a repository. Then should be accessible only with direct url. Never display on explore/organization.
In this case repositories should be accessible only on direct access.

About repositories looks great as proposed.

@DblK
Copy link
Member

DblK commented May 19, 2017

If the "never" option is implemented. The organization will be shown nowhere.
Not in the profil, not in the list even if we are member of that organization only by link.

That suppose you will keep the link outside of Gitea and hoping you won't loose it.
For me, I don't see the use of this fourth option.

I will begin the implementation without it.

@camlafit
Copy link
Contributor Author

camlafit commented May 19, 2017 via email

@DblK
Copy link
Member

DblK commented May 19, 2017

Perfect. The suggestion was complete.
Actually I personally need this feature so I will implement it soon.

@bkcsoft
Copy link
Member

bkcsoft commented May 19, 2017

Don't implement what you don't use, otherwise you'll never finish 😉

@camlafit
Copy link
Contributor Author

camlafit commented May 19, 2017 via email

@DblK
Copy link
Member

DblK commented May 19, 2017

So the UI will be like this:

image

@camlafit
Copy link
Contributor Author

camlafit commented May 19, 2017 via email

@DblK
Copy link
Member

DblK commented May 22, 2017

I will add more options for this feature but you (@camlafit) can already test the PR and tell me if I have thing to do. I will check the activity feed just in case.

@camlafit
Copy link
Contributor Author

Hi

I'll test this afternoon.

@camlafit camlafit changed the title Set private status about Organization and User (not logged) Set private status about Organization (not logged) May 23, 2017
@amigrave
Copy link

A lots of PR gets flagged as duplicates to this one but the status of #714 keeps stalled.
Is this issue solved in another way ?

@stale
Copy link

stale bot commented Jan 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 8, 2019
@techknowlogick
Copy link
Member

Commenting to remove stale status

@stale stale bot removed the issue/stale label Jan 8, 2019
@techknowlogick techknowlogick added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 25, 2019
@rakshith-ravi
Copy link
Contributor

Are there any hopes of seeing this in 1.8?

@lunny
Copy link
Member

lunny commented Feb 11, 2019

It should be, see #1763

@rakshith-ravi
Copy link
Contributor

Oh. Didn't see that. My bad. Thank you

@techknowlogick
Copy link
Member

closed as PR has been merged 🎉

@camlafit
Copy link
Contributor Author

Thanks a lot 🥇

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

7 participants