-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issues with conversation tab in PR with comments/threads and images/rst files changes #31412
Comments
This comment was marked as outdated.
This comment was marked as outdated.
Well, indeed ..... slow |
@wxiaoguang I updated to version 1.22-nightly, but nothing changed. PR conversation tab loading remained slow. Current version:
|
Thank you very much. I will try to reproduce it and try to fix |
I can reproduce it now. WIP: Fix tab performance #31437 . Need to figure out how to fix .... |
Thanks for the quick reply! Do you think it's not a combination of comments with closed reviews that can also have comments and just comments? I'm trying to reproduce the problem, and perfomance profile looks similar, but it loads faster, because in my problematic PR resolved reviews with comments and the comments themselves are more, which I mentioned in the first post, than in the test one. Here is my test repository: https://demo.gitea.com/ashakhba/application-perfomance-managment/pulls/1 |
That's another point, so maybe also related. |
According to this profile report, your instance's slowdown is 100% related to the
However, it could still be a problem (another problem ......) Are you able to run main-nightly (aka unreleased 1.23-nightly) in your production? If yes, I could provide more changes in the main branch, because some refactoring changes might not be suitable to backport to the stable 1.22 release. If you could only use 1.22.x at the moment .... I could try to backport some changes if they are proven to work in 1.23, but I can't 100% guarantee at the moment. |
This is the dev environment I reproduced using helm chart gitea from the prod gitea data and database, so I can update. The gitea/gitea:nightly-rootless from dockerhub is required version 1.23-nightly right? |
Yes, |
Related to #23461, and help some cases like #31412 For developers, they could use browser's Performance tool to collect performance data, while this PR is also quite handy to optimize the `index.js`. For end users, this PR is simple enough and could figure out the slow function quickly. ![image](https://github.com/go-gitea/gitea/assets/2114189/a557b08e-6594-474b-81a3-03d5ac2bd68e)
A new
|
Thanky you for quick update. I installed the version, and yes, it is indeed a bit slow, but not as slow as it was before, the difference is very strong, the page loads much faster (180 seconds -> ~30 seconds): Perfomance trace with option Link to bucket with performance profle json UPD: Changed to private. |
According to the latest profile:
I guess I have no new idea to do quick optimization at the moment, since that PR is really large. |
There are some config options in the |
And can you please explain, in the end no changes were made? I just see that only changed within the issue was the addition of "Add simple JS init performance trace #31459" and the behavior just changed within the latest changes from the main branch (nightly container in hub)? |
There are something made: for example: "Refactor image diff #31444" and optimize the tab related logic, it's a quite complex PR. So I can say that "The frontend slow-down problem should be almost resolved (it might be still a little slow not that slow)", these changes did improve the performance. So now the remaining problems are:
These tasks all depend on whether there are some contributors who have interests and time for it ..... |
Description
Hello Team,
We are experiencing significant slow loading times (about 3 minutes) in Gitea when dealing with pull requests (/docs/application-performance-management/pulls/6) that include about 580 review sections with 700 comments and file changes, with about 75 files involved. This problem occurs in Gitea version 1.19.3 and persists after upgrading to version 1.21.6, deployed on Kubernetes with Redis and an external PostgreSQL database. We've confirmed there are no issues with disk, CPU, or RAM usage, as well as with the database itself.
The pull request page, especially the "Conversation" tab, loads very slowly. However, if we recreate the pull request for the same branches and add a similar number of comments, using a simple word like "test" in each, the loading time is normal. This suggests that the slowdown may be related specifically to the opening of issue threads linked to certain parts of the code. The other tabs in the pull request, such as "Commits" and "Files Changes", load within a reasonable time.
It's important to note that there are several pull requests experiencing this issue, which suggests a consistent pattern or underlying problem.
Logs and Stacktrace outputs are in attachments:
gitea-logs.log
gitea-diagnosis-20240618-103535.zip
Could this issue be indicative of a bug, or is there a potential optimization strategy that we might consider? Any advice or assistance in resolving these slowdowns would be greatly appreciated.
Gitea Version
1.21.6
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
Git Version
2.40.1
Operating System
Linux gitea-85d5dc6896-6brvw 3.10.0-1062.18.1.el7.x86_64 #1 SMP Tue Mar 17 23:49:17 UTC 2020 x86_64 Linux
How are you running Gitea?
We are running Gitea on Kubernetes, deployed using the official Helm chart available at https://gitea.com/gitea/helm-chart. This setup includes Redis for caching and an external PostgreSQL database for data storage.
Database
PostgreSQL
The text was updated successfully, but these errors were encountered: